pkg/51347: multimedia/xine-lib fix for newer libdvdcss

[rhialto%falu.nl@localhost]

>Number:         51347
>Category:       pkg
>Synopsis:       multimedia/xine-lib fix for newer libdvdcss
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 19 21:05:00 +0000 2016
>Originator:     Rhialto
>Release:        NetBSD 7.0.1
>Organization:
	
>Environment:
	
	
System: NetBSD murthe.falu.nl 7.0.1 NetBSD 7.0.1 (GENERIC.201605221355Z) amd64
Architecture: x86_64
Machine: amd64
>Description:
	Since libdvdcss 1.4.0 the following problem exists with media players
	which indirectly use it (via libdvdnav) (including xine).

	You should be able to play a directory which contains the files as
	copied from a dvd, i.e. the VIDEO_TS directory. Libdvdcss, if present,
	will transparently use these (or play from a real dvd, if this was
	requested).

	Since libdvdcss 1.4.0 this does not work any more. I have included
	a new patch for that, which is based on the bug report I made at
	https://bugs.xine-project.org/show_bug.cgi?id=564 .

	Hopefully some equivalent of this will be included in the next release
	of xine-lib.

	Other media players may suffer from the same issue and the same fix;
	I plan to have a look at the ones I use.

>How-To-Repeat:
	Try to run xine dvd://some/directory/VIDEO_TS. See it fail if you
	have libdvdcss installed.
>Fix:

patch-src_input_input__dvd.c:

$NetBSD$

Environment variable fix for libdvdcss 1.4.0 and later.

--- src/input/input_dvd.c.orig	2016-07-19 20:02:16.000000000 +0000
+++ src/input/input_dvd.c
@@ -1401,7 +1401,11 @@ static int dvd_parse_try_open(dvd_input_
     /* we have an alternative dvd_path */
     intended_dvd_device = locator;
     /* do not use the raw device for the alternative */
+#if 1	 /* libdvdcss version 1.4.0 or later */
+    unsetenv("DVDCSS_RAW_DEVICE");
+#else
     xine_setenv("DVDCSS_RAW_DEVICE", "", 1);
+#endif
   } else {
     /* use default DVD device */
     dvd_input_class_t *class = (dvd_input_class_t*)this->input_plugin.input_class;

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert  -- Wayland: Those who don't understand X
\X/ rhialto/at/xs4all.nl    -- are condemned to reinvent it. Poorly.

>Unformatted: