Re: pkg/51424: pkgtools/libnbcompat string.h header does not properly guard strdup definition

[William Orr <will%worrbase.com@localhost>]

The following reply was made to PR pkg/51424; it has been noted by GNATS.

From: William Orr <will%worrbase.com@localhost>
To: gnats-bugs%NetBSD.org@localhost, joerg%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost,
 pkgsrc-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/51424: pkgtools/libnbcompat string.h header does not properly
 guard strdup definition
Date: Fri, 19 Aug 2016 15:22:17 -0700

 On 8/19/16 9:25 AM, Joerg Sonnenberger wrote:
 > The following reply was made to PR pkg/51424; it has been noted by GNATS.
 > 
 > From: Joerg Sonnenberger <joerg%bec.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: pkg/51424: pkgtools/libnbcompat string.h header does not
 >  properly guard strdup definition
 > Date: Fri, 19 Aug 2016 18:21:15 +0200
 > 
 >  On Thu, Aug 18, 2016 at 06:30:00AM +0000, will%worrbase.com@localhost wrote:
 >  > >Description:
 >  > When trying to build stuff that relies on libnbcompat on Linux,
 >  > compilation fails in the case that strdup is defined as a macro. There
 >  > seems to be a mistake in the feature guard for the function prototype in
 >  > libnbcompat
 >  
 >  The patch is not correct. The more interesting question would be why the
 >  configure check fails.
 >  
 >  Joerg
 >  
 > 
 
 Hey,
 
 It's not that the configure test fails, it's that the configure test
 doesn't define HAVE_DECL_STRDUP - it defines HAVE_STRDUP. Normally, this
 would just shadow the declaration of strdup, but because strdup is a
 macro on this system, the preprocessor mangles the definition in
 nbcompat/string.h. When the header compilation check runs on
 nbcompat/string.h, this results in a compilation failure.
 
 Thanks