pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/51445: new package: devel/dumpet
The following reply was made to PR pkg/51445; it has been noted by GNATS.
From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc:
Subject: Re: pkg/51445: new package: devel/dumpet
Date: Sat, 27 Aug 2016 05:08:52 +0000
On Fri, Aug 26, 2016 at 04:25:00PM +0000, nonakap%gmail.com@localhost wrote:
> dumpet is a tool to dump information about bootable CDs and other similar.
If it builds, please just commit it :-)
(It's a lot easier to review for minor quibbles and details after
commit than in gnats)
The one thing I see that I might do differently is
-CFLAGS:=-g3 -O2 -Wall -Werror
+CFLAGS+=-Wall
(or just comment it out) in place of
-CFLAGS:=-g3 -O2 -Wall -Werror
+CFLAGS:=-O2 -Wall -Werror
on the grounds that mostly one wants to inherit the pkgsrc CFLAGS
setting.
but that's really a minor detail...
--
David A. Holland
dholland%netbsd.org@localhost
Home |
Main Index |
Thread Index |
Old Index