Re: pkg/51424: pkgtools/libnbcompat string.h header does not properly guard strdup definition

[William Orr <will%worrbase.com@localhost>]

The following reply was made to PR pkg/51424; it has been noted by GNATS.

From: William Orr <will%worrbase.com@localhost>
To: gnats-bugs%NetBSD.org@localhost, joerg%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost,
 pkgsrc-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/51424: pkgtools/libnbcompat string.h header does not properly
 guard strdup definition
Date: Mon, 12 Sep 2016 21:06:40 -0700

 On 08/22/2016 01:45 AM, Joerg Sonnenberger wrote:
 > The following reply was made to PR pkg/51424; it has been noted by GNATS.
 > 
 > From: Joerg Sonnenberger <joerg%bec.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: joerg%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost,
 > 	will%worrbase.com@localhost
 > Subject: Re: pkg/51424: pkgtools/libnbcompat string.h header does not
 >  properly guard strdup definition
 > Date: Mon, 22 Aug 2016 10:41:16 +0200
 > 
 >  On Mon, Aug 22, 2016 at 03:35:01AM +0000, William Orr wrote:
 >  >  Not sure what I'm missing. autoconf (when building pkgin) *does* set
 >  >  HAVE_STRDUP, but *does not* set HAVE_DECL_STRDUP. None of the other
 >  >  functions are guarded by a prefix. ./configure *does* throw errors when
 >  >  the function is guarded by the HAVE_DECL_STRDUP macro, since strdup on
 >  >  Fedora is a macro itself.
 >  >  
 >  >  Why is strdup the only function that is guarded by a macro prefixed with
 >  >  HAVE_DECL_ instead of HAVE_ ? Not super clear as to why on that front
 >  >  either.
 >  
 >  Are we talking about libnbcompat or pkgin? They use different ways to
 >  check for strdup and different macros for the feature test.
 >  
 >  Joerg
 >  
 > 
 
 Ah yes, this is my bad. I'll send a patch to fix pkgin.
 
 Thanks!