pkg/51643: please add auth-request module to pkgsrc/www/nginx/options.mk

[waddell%caravaninfotech.com@localhost]

>Number:         51643
>Category:       pkg
>Synopsis:       please add auth-request module to pkgsrc/www/nginx/options.mk
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 22 23:00:00 +0000 2016
>Originator:     Harry Waddell
>Release:        pkgsrc current as of 11/22/16
>Organization:
Caravan Electronic Publishing, LLC
>Environment:
NetBSD  6.1_STABLE NetBSD 6.1_STABLE (GENERIC) amd64
>Description:
The auth-request module is commonly needed if one wants to authenticate against a credential sources other than a local passwd file. 

http://nginx.org/en/docs/http/ngx_http_auth_request_module.html

I've been using the attached patch for a few years now without issue. No further adaptation seems to be needed for use with pkgsrc. This is useful to support SSO and other external authentication schemes. 

I think adding it to the options is sufficient. As per the nginx docs, I don't think it needs to be added by default. 


>How-To-Repeat:
n/a
>Fix:
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/nginx/options.mk,v
retrieving revision 1.36
diff -u -r1.36 options.mk
--- options.mk	15 Jun 2016 14:49:11 -0000	1.36
+++ options.mk	22 Nov 2016 22:43:31 -0000
@@ -5,7 +5,7 @@
 			pcre push realip ssl sub uwsgi image-filter \
 			debug status nginx-autodetect-cflags echo \
 			set-misc headers-more array-var encrypted-session \
-			form-input perl gzip v2
+			form-input perl gzip v2 auth-request

 PKG_SUGGESTED_OPTIONS=	inet6 pcre ssl

@@ -216,3 +216,7 @@
 .if !empty(PKG_OPTIONS:Mgzip)
 CONFIGURE_ARGS+=	--with-http_gzip_static_module
 .endif
+
+.if !empty(PKG_OPTIONS:Mauth-request)
+CONFIGURE_ARGS+=        --with-http_auth_request_module
+.endif