pkg/52032: pkgsrc/www/firefox doesn't require pysqlite2

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         52032
>Category:       pkg
>Synopsis:       pkgsrc/www/firefox doesn't require pysqlite2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 04 21:30:00 +0000 2017
>Originator:     Izumi Tsutsui
>Release:        NetBSD 7.1_RC2 + pkgsrc 2016Q4
>Organization:
>Environment:
System: NetBSD mirage 7.1_RC2 NetBSD 7.1_RC2 (GENERIC.201702210739Z) i386
Architecture: i386
Machine: i386
>Description:
pkgsrc/www/firefox/mozilla-common.mk includes the following lines:
---
PYTHON_VERSIONS_ACCEPTED=	27
PYTHON_FOR_BUILD_ONLY=		yes
PYTHON_VERSIONS_INCOMPATIBLE=	34 35 36 # py-sqlite2
.include "../../lang/python/application.mk"
CONFIGURE_ENV+=		PYTHON=${PYTHONBIN:Q}

 :

#
# pysqlite2 is used by xulrunner's Python virtualenv.  If pysqlite2 isn't
# installed at build time it will attempt to download it instead, so the
# problem is stealthy in a networked environment, and obvious in an
# offline environment.
#
BUILD_DEPENDS+=	${PYPKGPREFIX}-sqlite2-[0-9]*:../../databases/py-sqlite2
---

These build dependency seems leftover for the separate devel/xulrunner
in past. Firefox was changed not to depend on it on 23th May 2013:
 http://mail-index.netbsd.org/pkgsrc-changes/2013/05/23/msg089599.html
and it looks pysqlite2 is no longer necessary.

>How-To-Repeat:
N/A (change request with code inspection and brief tests)

>Fix:
Just remove thses lines?

Index: mozilla-common.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox/mozilla-common.mk,v
retrieving revision 1.88
diff -u -p -r1.88 mozilla-common.mk
--- mozilla-common.mk	20 Feb 2017 12:22:53 -0000	1.88
+++ mozilla-common.mk	26 Feb 2017 01:02:27 -0000
@@ -89,12 +89,6 @@ CONFIG_SUB_OVERRIDE+=		${MOZILLA_DIR}js/
 CONFIG_SUB_OVERRIDE+=		${MOZILLA_DIR}nsprpub/build/autoconf/config.sub
 CONFIG_SUB_OVERRIDE+=		${MOZILLA_DIR}/js/ctypes/libffi/config.sub
 
-PYTHON_VERSIONS_ACCEPTED=	27
-PYTHON_FOR_BUILD_ONLY=		yes
-PYTHON_VERSIONS_INCOMPATIBLE=	34 35 36 # py-sqlite2
-.include "../../lang/python/application.mk"
-CONFIGURE_ENV+=		PYTHON=${PYTHONBIN:Q}
-
 SUBST_CLASSES+=		python
 SUBST_STAGE.python=	pre-configure
 SUBST_MESSAGE.python=	Fixing path to python.
@@ -153,14 +147,6 @@ CONFIGURE_ARGS+=	--enable-macos-target=1
 CONFIGURE_ARGS+=	--enable-macos-target=10.5
 .endif
 
-#
-# pysqlite2 is used by xulrunner's Python virtualenv.  If pysqlite2 isn't
-# installed at build time it will attempt to download it instead, so the
-# problem is stealthy in a networked environment, and obvious in an
-# offline environment.
-#
-BUILD_DEPENDS+=	${PYPKGPREFIX}-sqlite2-[0-9]*:../../databases/py-sqlite2
-
 # Makefiles sometimes call "rm -f" without more arguments. Kludge around ...
 .PHONY: create-rm-wrapper
 pre-configure: create-rm-wrapper