pkg/52051: net/tcpdump requires _tcpdump user but user creation fails

[mj%mjturner.net@localhost]

>Number:         52051
>Category:       pkg
>Synopsis:       net/tcpdump requires _tcpdump user but user creation fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 08 21:35:00 +0000 2017
>Originator:     Michael-John Turner
>Release:        HEAD
>Organization:
>Environment:
Darwin tesla.xx.yy 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64
>Description:
Package net/tcpdump builds successfully but installation fails as the _tcpdump user is required but the package doesn't create it:

===> Installing for tcpdump-4.9.0nb1
[ -d /usr/obj/pkg/net/tcpdump/work/.destdir/usr/pkg/sbin ] ||  (mkdir -p /usr/obj/pkg/net/tcpdump/work/.destdir/usr/pkg/sbin; chmod 755 /usr/obj/pkg/net/tcpdump/work/.destdir/usr/pkg/sbin)
/usr/bin/install -c  -o root -g wheel -m 755 tcpdump /usr/obj/pkg/net/tcpdump/work/.destdir/usr/pkg/sbin/tcpdump
[ -d /usr/obj/pkg/net/tcpdump/work/.destdir/usr/pkg/man/man1 ] ||  (mkdir -p /usr/obj/pkg/net/tcpdump/work/.destdir/usr/pkg/man/man1; chmod 755 /usr/obj/pkg/net/tcpdump/work/.destdir/usr/pkg/man/man1)
/usr/bin/install -c -o root -g wheel -m 644 tcpdump.1 /usr/obj/pkg/net/tcpdump/work/.destdir/usr/pkg/man/man1/tcpdump.1
=> Automatic manual page handling
=> Creating binary package /usr/obj/pkg/net/tcpdump/work/.packages/tcpdump-4.9.0nb1.tbz
===> Building binary package for tcpdump-4.9.0nb1
=> Creating binary package /usr/obj/pkg/packages/16.4.0/x86_64//All/tcpdump-4.9.0nb1.tbz
===> Installing binary package of tcpdump-4.9.0nb1
===========================================================================
The following users need to be created for tcpdump-4.9.0nb1:

	_tcpdump: , /var/empty, /usr/bin/false

===========================================================================
pkg_add: install script returned error status
pkg_add: 1 package addition failed
*** Error code 1
>How-To-Repeat:
1. Build a package for net/tcpdump on a platform that doesn't already have a _tcpdump user (eg, macOS).
2. Install the package.
3. Package installation fails (see above).


>Fix:
A similar package that builds and installs successfully is security/stunnel. It creates an stunnel user successfully.

The tcpdump Makefile _should_ create the user:
...
PKG_USERS=              _tcpdump
...