pkg/52215: chat/bitlbee update to 3.5.1

[triaxx%triaxx.org@localhost]

>Number:         52215
>Category:       pkg
>Synopsis:       chat/bitlbee update to 3.5.1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat May 06 19:25:00 +0000 2017
>Originator:     Frédéric Fauberteau
>Release:        pkgsrc-2017Q1
>Organization:
>Environment:
NetBSD trashware 7.1_STABLE NetBSD 7.1_STABLE (TRASHWARE) #0: Sat Mar 18 13:42:25 CET 2017  triaxx@guardian:/home/triaxx/netbsd/usr/objdir/sys/arch/amd64/compile/TRASHWARE amd64
>Description:
New versions are avaible:

Version 3.5.1:

- purple:
  * Fix crash on file transfer requests from unknown contacts. This was the
    result of an incomplete fix in the previous release and may result in
    remote DoS. Read the full security advisory at:
    https://bugs.bitlbee.org/ticket/1282
- After some investigation we decided to reclassify a crash fix from the
  previous release as a security issue. Read the full security advisory at:
  https://bugs.bitlbee.org/ticket/1281
- Included help.txt in the release tarball, which was missing in the previous
  release and resulted in adding python as a build dependency. The release
  tarball of 3.5.1 does not require python. 

Finished 30 Jan 2017

Version 3.5:

- ui:
  * "chat list": shows a list of existing server-side chatrooms. With some
    protocols, this is often the only way to add new channels.
    See 'help chat list' for details. (jgeboski)
  * "plugins": lists the installed plugins and their versions (jgeboski)
  * Add 'nick_lowercase' and 'nick_underscores' settings.
  * "handle_unknown" can be set per-account, not just globally

- jabber:
  * Add "always_use_nicks" channel setting, for non-anonymous MUCs (trac #415)
    See 'help set always_use_nicks' for possible side effects.
  * Properly handle rejected file transfers
  * Don't send parts in a chat if someone is still connected from other devices
  * hipchat: support personal oauth tokens (manually generated ones)

- twitter:
  * Hide muted tweets / no-retweets, add mute/unmute commands (Flexo)
  * Show full version of extended tweets (with slightly more than 140 chars)

- purple:
  * Support setting chat room topics (EionRobb)
  * Support for extra groupchat settings. Shows an error if any required
    ones are missing. Look for purple_ prefixed settings in "chan #... set"
  * SIPE: persistent chats can be joined now, thanks to the "chat list" command
    and the above ("purple_uri" channel setting)
  * Fix a file transfer crash bug (Mainly affected telegram)
  * Honor protocol flag to not require a password (used in hangouts, telegram)
  * Set the contacts' nicks to the %full_name for a few whitelisted protocols
    (hangouts, funyahoo, icq, line)
  * LINE: added a hack to save its auth token, to avoid re-auth every time
  * Show self-messages in groupchat backlogs (before join)

- yahoo:
  * Removed because they killed their old protocol on a two month notice.
    Use EionRobb's funyahoo purple plugin, or better yet, don't use yahoo.

- Stuff for enterprise deployments (all done by Sevas)
  * Locked down accounts, useful when pregenerating user config files. An
    account that is marked with the locked="true" attribute can't be removed
    and its username/password can't be changed.
  * Locked down settings. Same as above, but for individual account settings.
  * AllowAccountAdd setting in bitlbee.conf, to disable adding new accounts.
  * PAM and LDAP authentication backends (not compiled by default)

- For packagers:
  * Enabled debug symbols in non-debug builds, disabled stripping by default.
    This is closer to the default behavior of autotools, and --debug=1 is mostly
    to set the DEBUG macro and disable optimization.

- For plugin devs:
  * Plugins should now include an "init_plugin_info" function which will be used
    for ABI version checking in the future. It's optional for now, but will be
    enforced later. See the commit log of d28fe1c for details. (jgeboski)

Finished 8 Jan 2017

Version 3.4.2:
- irc:
  * Self-messages (messages sent by yourself from other IM clients), given
    support by the IM protocols and your IRC client. See this for details:
    https://wiki.bitlbee.org/SelfMessages
  * IRCv3.1 support and part of 3.2: cap-3.2, sasl-3.2, multi-prefix,
    away-notify, extended-join, userhost-in-names
  * Send numeric errors when failing to join a channel, to not confuse clients
  * Channel autojoins should be more reliable now.
- jabber:
  * Carbons (XEP-0280), for self-message support. It's not widely supported
    by most public XMPP servers (easier if you host your own), but this will
    probably change in the next few years. Thanks kormat for the original patch.
  * Fix typing notifications between two bitlbee users or with gtalk users
  * Remove facebook XMPP code, point people at bitlbee-facebook.
  * Show groupchat kick/ban/leave reasons
  * SASL ANONYMOUS (XEP-0175), for "guest" logins, see "help set anonymous"
  * Hipchat: 'chat add hipchat "channel name"' now tries to guess the JID
- purple:
  * Fix problems remembering SSL certificates as trusted
  * Fix /join #channel, which joined a differently named channel
  * Fix crash when doing "chat with" with skypeweb
  * Fix html entities appearing in some protocols
  * Fix setting away states in jabber, which failed silently
  * Implement notify_message UI op, to be able to show some error messages.
- skype:
  * Show all messages as groupchats since we can't tell which ones are private.
  * This plugin is mostly-deprecated and mostly-broken but it's still useful
    for p2p-based groupchats, which aren't delivered over newer protocols.
    Everyone else should use the skypeweb purple plugin or msn instead.
- msn:
  * Minor tweaks. Faster login, better error reporting, fixed add/remove.
    Still MSNP21. Disregard that "Next release!" in the previous release.
- otr:
  * Don't use NOTICE for user messages (revmischa)
  * Fix crashes when using the jabber xmlconsole
  * A few minor fixes: color multiline messages, filter incoming color codes.
- Packaging:
  * Show ./configure args in bitlbee -V, config.h and Makefile.settings
  * Allow setting the plugin dir in bitlbee.conf, for NixOS (anderspapitto)
  * Improved cross compiler support (gamaral)
- Other important bugfixes:
  * Fix potential crashes when leaving temporary channels
  * Fix all sorts of crashing bugs when cancelling in-progress connections.

Finished 19 Mar 2016
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/chat/bitlbee/Makefile,v
retrieving revision 1.71
diff -u -u -r1.71 Makefile
--- Makefile	19 Sep 2016 13:04:19 -0000	1.71
+++ Makefile	6 May 2017 19:12:12 -0000
@@ -1,7 +1,6 @@
 # $NetBSD: Makefile,v 1.71 2016/09/19 13:04:19 wiz Exp $
 
-DISTNAME=		bitlbee-3.4.1
-PKGREVISION=		1
+DISTNAME=		bitlbee-3.5.1
 CATEGORIES=		chat
 MASTER_SITES=		http://get.bitlbee.org/src/
 
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/chat/bitlbee/distinfo,v
retrieving revision 1.33
diff -u -u -r1.33 distinfo
--- distinfo	3 Nov 2015 01:20:17 -0000	1.33
+++ distinfo	6 May 2017 19:12:12 -0000
@@ -1,7 +1,7 @@
 $NetBSD: distinfo,v 1.33 2015/11/03 01:20:17 agc Exp $
 
-SHA1 (bitlbee-3.4.1.tar.gz) = b77311b538ec1c584694784f119b99fb6b3f4859
-RMD160 (bitlbee-3.4.1.tar.gz) = 32e0faf3b0a23f812f46752c1d0e96e30aaaf649
-SHA512 (bitlbee-3.4.1.tar.gz) = fad297c7a792c932ba74daf7dc894883037842ae5d39a4c831c6615100580073001806c1af60555aa1c775399e8a484d99a4e601e96c6a075e12546e5d153532
-Size (bitlbee-3.4.1.tar.gz) = 688072 bytes
+SHA1 (bitlbee-3.5.1.tar.gz) = de0767facdb7729253ae4d6ef6e3637ebd54939a
+RMD160 (bitlbee-3.5.1.tar.gz) = f7c3c6154d3c28cb1e48ccb5f86dbb9141795cea
+SHA512 (bitlbee-3.5.1.tar.gz) = 4eb3b0d3a92910c8dd789cd23338cc6296bf40212c5244fcb27a88ede10e86424ea59c78e719841863701a7fdd8c61819f2775f7b58833e287d9110e49d036f3
+Size (bitlbee-3.5.1.tar.gz) = 680351 bytes
 SHA1 (patch-irc__channel.c) = 332126961c675c173fd3634fcb26877a3317acd0
Index: patches/patch-irc__channel.c
===================================================================
RCS file: patches/patch-irc__channel.c
diff -N patches/patch-irc__channel.c
--- patches/patch-irc__channel.c	27 Aug 2015 21:58:42 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,39 +0,0 @@
-$NetBSD: patch-irc__channel.c,v 1.1 2015/08/27 21:58:42 wiz Exp $
-
-From b6a3fbf3b94d1e7e7aee82375661fc0934fec48b Mon Sep 17 00:00:00 2001
-From: dequis <dx%dxzone.com.ar@localhost>
-Date: Thu, 27 Aug 2015 04:25:07 -0300
-Subject: [PATCH] irc_channel_name_gen: handle g_convert_with_fallback failures
-
-First fallback to ASCII without TRANSLIT, and if that fails too, just
-give up by returning NULL.
-
-Basically the same thing as 3a27896 (a netbsd specific fix), but for
-channel names. This wasn't needed before because the older version of
-this code caught the NULL from the ASCII//TRANSLIT attempt and gave up
-immediately, while the refactored version lacked null checking.
----
- irc_channel.c | 10 ++++++++++
- 1 file changed, 10 insertions(+)
-
-diff --git a/irc_channel.c b/irc_channel.c
-index 3de68e3..cbd306a 100644
---- irc_channel.c.orig	2015-06-16 22:30:40.000000000 +0000
-+++ irc_channel.c
-@@ -592,6 +592,16 @@ char *irc_channel_name_gen(irc_t *irc, c
- 	gsize bytes_written;
- 
- 	translit_name = g_convert_with_fallback(hint, -1, "ASCII//TRANSLIT", "UTF-8", "", NULL, &bytes_written, NULL);
-+
-+      if (!translit_name) {
-+              /* Same thing as in nick_gen() in nick.c, try again without //TRANSLIT */
-+              translit_name = g_convert_with_fallback(hint, -1, "ASCII", "UTF-8", "", NULL, &bytes_written, NULL);
-+      }
-+
-+      if (!translit_name) {
-+              return NULL;
-+      }
-+
- 	if (bytes_written > MAX_NICK_LENGTH) {
- 		translit_name[MAX_NICK_LENGTH] = '\0';
- 	}