pkg/52248: xrolodex core dumps on amd64 (64 bit) machines

[mlr%rse.com@localhost]

>Number:         52248
>Category:       pkg
>Synopsis:       xrolodex core dumps on amd64 (64 bit) machines.
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 20 20:05:00 +0000 2017
>Originator:     Michael L. Riechers
>Release:        NetBSD 7.1_RC2
>Organization:
Kind Regards, I am

 /s/ Michael L. Riechers

Michael L. Riechers,
Owner,					M L Riechers Systems Engineering
513/844-2220 (voice)			530 Main Street
513/205-5589 (cell)			Hamilton, Ohio 45013
513/844-2279 (fax)
mlr%rse.com@localhost  (internet)
www.rse.com  (WEB)

Systems Programming: The three most adverse malignancies in life are:
  1)signed numbers,  2)floating point numbers, and  3)little endians.

Adams wrote to his fellow founding father Thomas Jefferson in 1816:
"Britain will never be our Friend, till We are her Master"
So I propose:
"MicroSoft will never be our Friend, till We are her Master"
>Environment:
	
	
System: NetBSD cterm.rse.com 7.1_RC2 NetBSD 7.1_RC2 (HOUSE-7.1_RC2) #0: Sun Feb 26 11:56:07 EST 2017 root%cterm.rse.com@localhost:/usr/local/src/usr/usr.201702210824Z/src/sys/arch/amd64/compile/obj/HOUSE-7.1_RC2 amd64
Architecture: x86_64
Machine: amd64
>Description:
xrolodex core dumps on amd64 (64 bit) machines.
	
>How-To-Repeat:
	
1. Compile xrolodex.
2. Start xrolodex.
3. xrolodex immediately core dumps.
>Fix:
	
add into xrolo.h:
38a39
#include <Xm/FileSB.h>

this wipes out xrolodex's confusion regarding 32 vs 64 bit references.

it does not, however, get rid of these confusions:

xrolo.c: In function 'FileSelectionOK':
xrolo.c:1035:6: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if ((int) client_data == xrolo_OPEN)
      ^
xrolo.c:1037:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  else if ((int) client_data == xrolo_SAVE_AS) {
           ^
xrolo.c: In function 'SaveUnsavedChanges':
xrolo.c:1085:6: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if ((int) client_data == xrolo_EXIT_WARNING) {
      ^
xrolo.c:1089:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  else if ((int) client_data == xrolo_OPEN_WARNING) {
           ^
xrolo.c: In function 'DiscardUnsavedChanges':
xrolo.c:1114:6: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if ((int) client_data == xrolo_EXIT_WARNING) {
      ^
xrolo.c:1118:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  else if ((int) client_data == xrolo_OPEN_WARNING) {
           ^
xrolo.c: In function 'CancelUnsavedChanges':
xrolo.c:1143:6: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if ((int) client_data == xrolo_EXIT_WARNING)
      ^
xrolo.c:1145:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  else if ((int) client_data == xrolo_OPEN_WARNING)
           ^
xrolo.c: In function 'Sort':
xrolo.c:1479:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  temp_entry = ((int) client_data == xrolo_ASCEND) ?
                ^ 

I don't know if these matter, especially on other architectures.  It
doesn't seem to bother me.

Yours,

-Mike

>Unformatted: