Re: pkg/52693: cldr-emoji-annotation: new package (for ibus emoji-dict support)

[Benny Siegert <bsiegert%gmail.com@localhost>]

> Package files are attached in shar format.
> Also available on gist:
>  https://gist.github.com/tsutsui/ef0745f3600e3e8e2ffdefb5d9dc535b

Personally, I would prefer if that were a multi-file gist instead of
the shell archive again :).

> - CATEGORIES should be discussed (currently in "fonts")

It's not a font per se. print or textproc would be better choices.

> - PKGNAME is tweaked from DISTNAME for version strings
>   (31.90.0_1 -> 31.90.0.1)

Good.

> - DISTFILES is from github repo prepared by the fedora maintainer
>   (who is also a maintainer of ibus)
>    https://github.com/fujiwarat/cldr-emoji-annotation
>   because the original unicode.org has no archive and versioning:
>    http://www.unicode.org/repos/cldr/trunk/common/annotations/

That's fine.

> - fedora specifies "LGPLv2+ and Unicode" for license,
>    https://bugzilla.redhat.com/show_bug.cgi?id=1428287#c2
>   but only "LICENSE=unicode" is specified because
>   installed annotation files are in Unicode license
>   (binaries to generate "annotationsDerived" files during do-build
>    use LGPLv2 libs but they are not installed)

That's also fine.

> - NO_CONFIGURE is set because bandled "autogen.sh" srcipt handles libtools etc.

I have not looked at the contents of autogen.sh. But I would probably
just run "autoreconf" in pre-configure and leave the configure target
as is.

If you do decide to stay with autogen.sh, you should run it in
do-configure, not do-build.

> - files are installed to ${PREFIX}/share/unicode/cldr/common/
>   as upstream recommends (which seems suggested by fedora)
>    https://bugzilla.redhat.com/show_bug.cgi?id=1428287#c2
> - no warning by pkglint

Both are good.

Please commit after addressing the points above.