pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/52697: new package chat/line-purple



>Number:         52697
>Category:       pkg
>Synopsis:       new package chat/line-purple
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 04 19:35:01 +0000 2017
>Originator:     scole_mail
>Release:        pkgsrc current
>Organization:
none
>Environment:
NetBSD dstar 7.1.0_PATCH NetBSD 7.1.0_PATCH (GENERIC) #0: Fri Sep  8 20:45:12 PDT 2017  scole@dstar:/home/scole/nbsd/cvs/7_0/obj/sys/arch/i386/compile/GENERIC i386
>Description:
I created a new package chat/line-purple from this project
 http://altrepo.eu/git/purple-line
It is basically the LINE chat plugin for pidgin
 https://developer.pidgin.im/wiki/ThirdPartyPlugins

I attempted to modify the package to use libtool, maybe someone could verify my changes aren't too horrible.

Also, the repo is in a git-style repo without the github.com name.  I couldn't get the package to fetch to anything other than distfiles/line-purple-0.1/archive.zip .  Maybe another way would be preferred.

I tested the package and it seems to work fine for basic chatting.

2 patches are included below.

Thanks


Summary of changes:  (A/? = New, R/D = Removed, M = Modified)
=============================================================
? line-purple/
? line-purple/DESCR
? line-purple/Makefile
? line-purple/PLIST
? line-purple/distinfo
? line-purple/patches/
? line-purple/patches/patch-libpurple_Makefile
M Makefile

Apply patch with "cd .../pkgsrc/chat ; patch -s -p0 < .../patchfile"

--- /dev/null	2017-11-04 12:09:27.000000000 -0700
+++ line-purple/DESCR	2017-10-23 08:55:35.000000000 -0700
@@ -0,0 +1 @@
+This is a libpurple (Pidgin, Finch) protocol plugin for LINE.
--- /dev/null	2017-11-04 12:09:27.000000000 -0700
+++ line-purple/Makefile	2017-11-04 12:08:14.000000000 -0700
@@ -0,0 +1,56 @@
+# $NetBSD: Makefile,v 1.1 2017/10/23 08:57:06 scole Exp $
+
+VERSION=	0.1
+PKGNAME=	line-purple-${VERSION}
+
+CATEGORIES=	chat
+
+MAINTAINER=	pkgsrc-users%NetBSD.org@localhost
+HOMEPAGE=	http://altrepo.eu/git/purple-line/
+COMMENT=	LINE protocol plugin for libpurple (pidgin, finch)
+
+# XXX archive is at a github-type site, but its name doesn't
+# match "https://github.com/account";, couldn't figure out
+# pkgsrc GITHUB* vars to work for fetching
+#ALTREPO_TAG=	b330e2b07372d0aea0100ab5a75ba5a6961b475c
+
+MASTER_SITES=   ${HOMEPAGE:=repository/}
+EXTRACT_SUFX=	.zip
+DISTNAME=	archive
+DIST_SUBDIR=	${PKGNAME}
+
+LICENSE=	line-purple
+
+WRKSRC=		${WRKDIR}/purple-line.git
+
+USE_LIBTOOL=	yes
+USE_TOOLS+=	gmake pkg-config
+
+USE_LANGUAGES=	c++
+
+INSTALLATION_DIRS=	lib/purple-2 \
+			share/pixmaps/pidgin/protocols/16 \
+			share/pixmaps/pidgin/protocols/22 \
+			share/pixmaps/pidgin/protocols/48 \
+			share/pixmaps/pidgin/protocols/scalable \
+			share/doc/line-purple
+
+PIDGIN_PROTO_DIR=	${DESTDIR}${PREFIX}/share/pixmaps/pidgin/protocols
+
+do-install:
+		cd ${WRKSRC}/libpurple && ${LIBTOOL} --mode=install \
+		  ${INSTALL_LIB} libline.la ${DESTDIR}${PREFIX}/lib/purple-2
+		for i in 16 22 48; do cd ${WRKSRC}/icons && \
+		  ${INSTALL_DATA} $$i/line.png ${PIDGIN_PROTO_DIR}/$$i; done
+		${INSTALL_DATA} ${WRKSRC}/icons/scalable/line.svg \
+		  ${DESTDIR}${PREFIX}/share/pixmaps/pidgin/protocols/scalable
+		${INSTALL_DATA} ${WRKSRC}/README.md ${DESTDIR}${PREFIX}/share/doc/line-purple
+
+.include "../../chat/libpurple/buildlink3.mk"
+.include "../../devel/boost-headers/buildlink3.mk"
+.include "../../devel/boost-libs/buildlink3.mk"
+.include "../../devel/libidn/buildlink3.mk"
+.include "../../devel/libthrift/buildlink3.mk"
+.include "../../security/libgcrypt/buildlink3.mk"
+
+.include "../../mk/bsd.pkg.mk"
--- /dev/null	2017-11-04 12:09:27.000000000 -0700
+++ line-purple/PLIST	2017-11-04 10:58:24.000000000 -0700
@@ -0,0 +1,7 @@
+@comment $NetBSD: PLIST,v 1.1 2017/10/23 13:24:47 scole Exp $
+lib/purple-2/libline.la
+share/pixmaps/pidgin/protocols/16/line.png
+share/pixmaps/pidgin/protocols/22/line.png
+share/pixmaps/pidgin/protocols/48/line.png
+share/pixmaps/pidgin/protocols/scalable/line.svg
+share/doc/line-purple/README.md
--- /dev/null	2017-11-04 12:09:27.000000000 -0700
+++ line-purple/distinfo	2017-11-04 12:07:39.000000000 -0700
@@ -0,0 +1,7 @@
+$NetBSD: distinfo,v 1.7 2016/03/28 00:17:12 gdt Exp $
+
+SHA1 (line-purple-0.1/archive.zip) = 2ee693cc9ba7fe0b833a0a932051dc9160ef4896
+RMD160 (line-purple-0.1/archive.zip) = 24c85b728dc53a0494e002c1115dec4b7420e374
+SHA512 (line-purple-0.1/archive.zip) = cb41ff49207678966554e1c96234fd6062340a1470df7536fdbe536ac78c94c598b179fca14a702e41f49ecc950975f8e865b4764d5ffec5f458d000c056c515
+Size (line-purple-0.1/archive.zip) = 56114 bytes
+SHA1 (patch-libpurple_Makefile) = b682cf9197fc3ea0f359410a7f79a361fd9f36bc
--- /dev/null	2017-11-04 12:09:27.000000000 -0700
+++ line-purple/patches/patch-libpurple_Makefile	2017-11-04 11:26:55.000000000 -0700
@@ -0,0 +1,35 @@
+$NetBSD: patch-libpurple_Makefile,v 1.1 2017/11/04 11:22:31 scole Exp $
+
+Modify for libtool
+
+--- libpurple/Makefile.orig	2017-03-30 23:35:47.000000000 +0000
++++ libpurple/Makefile		2017-07-04 11:22:31.000000000 +0000
+@@ -15,10 +15,10 @@ CXX ?= g++
+ CXXFLAGS = -g -Wall -shared -fPIC \
+ 	-DHAVE_INTTYPES_H -DHAVE_CONFIG_H -DPURPLE_PLUGINS \
+ 	`pkg-config --cflags purple` `libgcrypt-config --cflags` `gpg-error-config --cflags` \
+-	$(THRIFT_CXXFLAGS)
++	`pkg-config --cflags libidn` $(THRIFT_CXXFLAGS)
+ 
+ LIBS = `pkg-config --libs purple` `libgcrypt-config --libs` `gpg-error-config --libs` \
+-	$(THRIFT_LIBS)
++       `pkg-config --libs libidn` $(THRIFT_LIBS)
+ 
+ PURPLE_PLUGIN_DIR:=$(shell pkg-config --variable=plugindir purple)
+ PURPLE_DATA_ROOT_DIR:=$(shell pkg-config --variable=datarootdir purple)
+@@ -39,11 +39,12 @@ OBJS = $(SRCS:.cpp=.o)
+ all: $(MAIN)
+ 
+ $(MAIN): $(OBJS) $(THRIFT_DEP)
+-	$(CXX) $(CXXFLAGS) -Wl,-z,defs -o $(MAIN) $(OBJS) $(LIBS)
+-	strip $(MAIN)
++	$(LIBTOOL) --mode=link $(CXX) $(CXXFLAGS) \
++		-module -avoid-version -o $(MAIN:.so=.la) $(OBJS:.o=.lo) $(LIBS:.a=.la) \
++		-rpath $(PREFIX)/lib/purple-2
+ 
+ .cpp.o:
+-	$(CXX) $(CXXFLAGS) -std=c++11 -c $< -o $@
++	$(LIBTOOL) --mode=compile $(CXX) $(CXXFLAGS) -std=c++11 -c $< -o $@
+ 
+ # The Thrift generator generates three files at once, this file shall represent them.
+ thrift_line/TalkService.cpp: line.thrift $(THRIFT_DEP) $@
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/chat/Makefile,v
retrieving revision 1.195
diff -b -u -r1.195 Makefile
--- Makefile	9 Oct 2017 08:16:35 -0000	1.195
+++ Makefile	4 Nov 2017 19:18:55 -0000
@@ -78,6 +78,7 @@
 SUBDIR+=	libtlen
 SUBDIR+=	licq-core
 SUBDIR+=	licq-gui-console
+SUBDIR+=	line-purple
 SUBDIR+=	loudmouth
 SUBDIR+=	matterircd
 SUBDIR+=	mcabber



Summary of changes:  (A/? = New, R/D = Removed, M = Modified)
=============================================================
? line-purple

Apply patch with "cd .../pkgsrc/licenses ; patch -s -p0 < .../patchfile"

--- /dev/null	2017-11-04 12:09:27.000000000 -0700
+++ line-purple	2017-10-30 19:52:52.000000000 -0700
@@ -0,0 +1,20 @@
+Copyright (c) 2014, 2015 Matti Virkkunen
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be included
+in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index