Re: pkg/52956 (firefox-58.0 fails to build on NetBSD/i386 7.1.1)

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR pkg/52956; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: ryoon%NetBSD.org@localhost, pkgsrc-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
        maya%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: pkg/52956 (firefox-58.0 fails to build on NetBSD/i386 7.1.1)
Date: Sun, 4 Feb 2018 11:28:06 +0900

 Sorry, I was a bit stupid.
 make build works with the patch, but the firefox binary immediately
 crashes after startup.
 
 It crashes at GetFromArgv0() in xpcom/build/BinaryPath.h
 (actually in realpath()), but I'm not sure if it works on OpenBSD.
 
 It looks using procfs like XP_LINUX works fine.
 
 ---
 $NetBSD: patch-xpcom_build_BinaryPath.h,v 1.3 2018/01/31 14:02:18 ryoon Exp $
 
 * Fix build under netbsd-7, PR pkg/52956
 
 --- xpcom/build/BinaryPath.h.orig	2018-01-11 20:17:07.000000000 +0000
 +++ xpcom/build/BinaryPath.h
 @@ -154,7 +154,8 @@ private:
      return NS_OK;
    }
  
 -#elif defined(XP_LINUX) || defined(XP_SOLARIS)
 +#elif defined(XP_LINUX) || defined(XP_SOLARIS) || \
 +      (defined(__NetBSD__) && !defined(KERN_PROC_PATHNAME))
    static nsresult Get(char aResult[MAXPATHLEN])
    {
  #  if defined(XP_SOLARIS)
 @@ -172,7 +173,8 @@ private:
    }
  
  #elif defined(__FreeBSD__) || defined(__DragonFly__) || \
 -      defined(__FreeBSD_kernel__) || defined(__NetBSD__)
 +      defined(__FreeBSD_kernel__) || \
 +      (defined(__NetBSD__) && defined(KERN_PROC_PATHNAME))
    static nsresult Get(char aResult[MAXPATHLEN])
    {
      int mib[4];
 
 ---