pkg/53035: devel/omake: on macOS, build fails due to not finding history_list() in readline headers

[bapabooiee%gmail.com@localhost]

>Number:         53035
>Category:       pkg
>Synopsis:       devel/omake: on macOS, build fails due to not finding history_list() in readline headers
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 18 01:40:00 +0000 2018
>Originator:     Dean Matzkov
>Release:        2017Q4
>Organization:
>Environment:
Darwin 17.4.0 Darwin Kernel Version 17.4.0: Sun Dec 17 09:19:54 PST 2017; root:xnu-4570.41.2~1/RELEASE_X86_64 x86_64
>Description:
On macOS, the build fails due to history_list() not being declared in a system-provided readline header, located in /usr/include/readline/history.h.

Here's a snippit from the build process:

-----SNIP-----
File "omake_gen_magic.ml", line 126, characters 8-17:===============                 ] 00974 / 01204
Warning 39: unused rec flag.
- build src/clib readline.o
+ clang -O2 -I/Users/bapa/pkg/include -I/usr/include -g -O2 -Wall -Werror -Wno-unused -DREADLINE_ENABLED -DREADLINE_GNU -DNCURSES -DFAM_ENABLED -DFAM_PSEUDO -DFAM_KQUEUE -DHAVE_STRING_H -DHAVE_STRINGS_H -DHAVE_SNPRINTF -DDETECT_FS_CASE_SENSITIVE_GETATTRLIST -I. -I/Users/bapa/pkg/lib/ocaml -I. -c -o readline.o readline.c
readline.c:1488:16: error: implicit declaration of function 'history_list' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    the_list = history_list();
               ^
readline.c:1488:16: note: did you mean 'history_get'?
/Volumes/Stuff/pkgsrc/devel/omake/work/.buildlink/include/readline/history.h:153:13: note: 'history_get' declared here
HIST_ENTRY      *history_get(int);
                 ^
readline.c:1488:14: error: incompatible integer to pointer conversion assigning to 'HIST_ENTRY **' (aka 'struct _hist_entry **') from 'int' [-Werror,-Wint-conversion]
    the_list = history_list();
             ^ ~~~~~~~~~~~~~~
2 errors generated.
*** omake: 975/1204 targets are up to date
*** omake: failed (27.56 sec, 233/233 scans, 234/314 rules, 599/1977 digests)
*** omake: targets were not rebuilt because of errors:
   src/clib/readline.o
      depends on: src/clib/readline.c
*** Error code 1

Stop.
----THY SNIP ENDS-----
>How-To-Repeat:
1. Make sure you're using macOS
2. cd $pkgsrc/devel/omake
3. bmake
>Fix:
Changing omake's Makefile so that it uses the pkgsrc-provided readline library/headers seems to have fixed the build for me. eg, something like changing

.include "../../mk/readline.buildlink3.mk"

to 

.include "../../devel/readline/buildlink3.mk"