Re: pkg/53063: USE_PKGLOCALEDIR broken?

[Thomas Klausner <wiz%NetBSD.org@localhost>]

The following reply was made to PR pkg/53063; it has been noted by GNATS.

From: Thomas Klausner <wiz%NetBSD.org@localhost>
To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
Cc: 
Subject: Re: pkg/53063: USE_PKGLOCALEDIR broken?
Date: Fri, 2 Mar 2018 08:56:05 +0100

 On Fri, Mar 02, 2018 at 08:48:36AM +0100, Frédéric Fauberteau wrote:
 > Le 2018-03-02 00:50, Thomas Klausner a écrit :
 > > The following reply was made to PR pkg/53063; it has been noted by
 > > GNATS.
 > > 
 > > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 > > To: NetBSD bugtracking <gnats-bugs%NetBSD.org@localhost>
 > > Cc:
 > > Subject: Re: pkg/53063: USE_PKGLOCALEDIR broken?
 > > Date: Fri, 2 Mar 2018 00:45:08 +0100
 > > 
 > >  That's a misunderstanding. The PLIST always has share/locale, this is
 > > automatically fixed.
 > > 
 > >  Compare PKGMANDIR, the PLIST always has man/manX for that too.
 > >   Thomas
 > 
 > Yes, I misunderstood USE_PKGLOCALEDIR because the PLIST of wip/lightdm
 > contained some lines like ${PKGLOCALEDIR}/locale/af/LC_MESSAGES/lightdm.mo
 
 That's wrong, just change it to "share/locale/..."
 
 > and its Makefile explicitly declared USE_PKGLOCALDIR=yes.
 > 
 > Since (1) a package is built for a given system and (2) PKGLOCALEDIR is not
 > a public configuration variable, ${PKGLOCALDIR} in PLIST seems useless.
 
 Correct.
 
 > According to mk/configure/replace-localedir.mk:
 > ######################################################################
 > ### replace-localedir (PRIVATE)
 > ######################################################################
 > [...]
 > .if empty(USE_PKGLOCALEDIR:M[nN][oO])
 > SUBST_CLASSES+=     pkglocaledir
 > .endif
 > 
 > Hence, I would remove the line 'USE_PKGLOCALDIR=yes' that sounds confusing
 > to me.
 
 That's wrong, the variable still does something useful on systems
 where LOCALEDIR is not share/locale.
  Thomas