pkg/53157: pkg_rolling-replace performs unsolicited top-level "make clean"

[gson%gson.org@localhost (Andreas Gustafsson)]

>Number:         53157
>Category:       pkg
>Synopsis:       pkg_rolling-replace performs unsolicited top-level "make clean"
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 05 14:45:00 +0000 2018
>Originator:     Andreas Gustafsson
>Release:        NetBSD 7.1.1
>Organization:

>Environment:
System: NetBSD
Architecture: x86_64
Machine: amd64
>Description:

When I run "pkg_rolling-replace -v -u -k" on a NetBSD installation old
enough that the installed emacs package is still called "emacs24",
after the expected ususuccessful attempt to update the emacs24
package, pkg_rolling-replace does a "make clean" at the top level of
the pkgsrc tree, without being asked to do so, taking a very long time
and generating many thousands of lines of output.

guru /usr/pkgsrc $ pkg_rolling-replace -v -u -k
RR> Checking for mismatched installed packages using pkg_chk
rr> WARNING: No editors/emacs24/Makefile - package moved or obsolete?
rr> WARNING: No print/tex-misc/Makefile - package moved or obsolete?
rr> Missing: editors/emacs24 print/tex-misc
RR> Excluding the following mismatched packages:
rr> EXCLUDE=[]
RR> Checking for rebuild-requested installed packages (rebuild=YES)
RR> Checking for unsafe installed packages (unsafe_depends=YES)
RR> Packages to rebuild:
rr> MISMATCH_TODO=[]
rr> REBUILD_TODO=[]
rr> UNSAFE_TODO=[emacs24]
RR> Building dependency graph for installed packages
RR> Tsorting dependency graph
RR> Selecting emacs24 (editors/emacs24) as next package to replace
RR> Checking if emacs24 has new depends...
cd: can't cd to /usr/pkgsrc/editors/emacs24
make: don't know how to make show-depends. Stop
make: don't know how to make show-depends. Stop
RR> emacs24 has the following new depends (need to re-tsort):
rr> [make0 stopped in /usr/pkgsrc]
RR> Tsorting dependency graph
RR> Selecting emacs24 (editors/emacs24) as next package to replace
*** No package directory 'editors/emacs24' for emacs24.
RR> Replacing emacs24-24.5nb20
===> x11
===> x11/9term
===> Cleaning for 9term-1.6.3nb1
===> x11/XaoS
===> Cleaning for xaos-3.6nb1
===> x11/Xaw-Xpm
===> Cleaning for Xaw-Xpm-1.1nb4
===> x11/Xbae
===> Cleaning for Xbae-4.51.01nb3
===> x11/Xfixes
===> Cleaning for Xfixes-2.0.1nb5
===> x11/XmHTML
===> Cleaning for XmHTML-1.1.7nb14
===> x11/Xrender
===> Cleaning for Xrender-0.9.0nb3
===> x11/alacarte
===> Cleaning for alacarte-0.13.1nb38
===> x11/antiright
===> Cleaning for antiright-3.4nb30
===> x11/appmenu-qt
===> Cleaning for appmenu-qt-0.2.6nb4
===> x11/appres
===> Cleaning for appres-1.0.5
===> x11/arandr
===> Cleaning for arandr-0.1.9nb3
===> x11/asnap
===> Cleaning for asnap-1.0nb2
===> x11/aterm
===> Cleaning for aterm-1.0.0nb16
===> x11/autocutsel
===> Cleaning for autocutsel-0.10.0
===> x11/avant-window-navigator
===> Cleaning for avant-window-navigator-0.4.0nb27
===> x11/bbapm
===> Cleaning for bbapm-0.0.1nb2
===> x11/beforelight
===> Cleaning for beforelight-1.0.5
===> x11/bitmap
===> Cleaning for bitmap-1.0.8
===> x11/blt
===> Cleaning for blt-2.4znb10
===> x11/c++-gtk-utils
===> Cleaning for c++-gtk-utils-2.2.15nb1
===> x11/clipit
===> Cleaning for clipit-1.4.2nb13
===> x11/clisp-gtk2
===> Cleaning for clisp-gtk2-2.49nb24
===> x11/clisp-mit-clx
===> Cleaning for clisp-mit-clx-2.49
===> x11/clisp-new-clx
===> Cleaning for clisp-new-clx-2.49nb2
===> x11/compton
===> Cleaning for compton-20150920
===> x11/deforaos-integration
===> Cleaning for deforaos-integration-0.0.2nb9
===> x11/deforaos-keyboard
===> Cleaning for deforaos-keyboard-0.3.1nb1
===> x11/deforaos-libdesktop
===> Cleaning for deforaos-libdesktop-0.2.2nb2
===> x11/deforaos-locker
===> Cleaning for deforaos-locker-0.4.0nb5
===> x11/deforaos-notes
===> Cleaning for deforaos-notes-0.1.0nb4
===> x11/deforaos-panel
===> Cleaning for deforaos-panel-0.3.6nb5
===> x11/desklaunch
[thousands of lines omitted for brevity]

>How-To-Repeat:

>Fix:

Perhaps the following patch?

--- pkg_rolling-replace.orig	2018-04-05 17:22:51.000000000 +0300
+++ pkg_rolling-replace	2018-04-05 17:23:04.000000000 +0300
@@ -496,6 +496,7 @@
     if [ -d "$PKGSRCDIR/$pkgdir" ]; then
 	cd "$PKGSRCDIR/$pkgdir";
     else
+        fail=1
         mark_as_failed $pkg
 	error "No package directory '$pkgdir' for $pkg."
     fi