pkg/53205: archivers/heirloom-tar.out:tar.c:1021: bad if test ?

[dcb314%hotmail.com@localhost]

>Number:         53205
>Category:       pkg
>Synopsis:       archivers/heirloom-tar.out:tar.c:1021: bad if test ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 23 07:50:00 +0000 2018
>Originator:     David Binderman
>Release:        cvs-20180418
>Organization:
>Environment:
>Description:
archivers/heirloom-tar.out:tar.c:1021:60: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

       while (**bp && (n = strtol(*bp, &x, 10)) <= 0 && (*x!=' ' || *x!='\t'))

Maybe better code

       while (**bp && (n = strtol(*bp, &x, 10)) <= 0 && (*x!=' ' && *x!='\t'))

>How-To-Repeat:

>Fix: