Re: pkg/53240: build vlc -2.2.6 from pkgsrc 2018Q1 fails

[Roy Bixler <rcbixler%nyx.net@localhost>]

On Tue, 22 May 2018 14:02:54 +0200, Joerg Sonnenberger wrote:
> The patch is just wrong.

That's unfortunate, but I'm not surprised.  After all, I don't know
how to test whether it works and I had no prior confirmation that it
was supposed to work.  It did make vlc buildable for me.  I also
mentioned another possible patch from

https://mail-index.netbsd.org/pkgsrc-users/2018/04/07/msg026466.html

I'll repeat it here:

--- modules/codec/x264.c.orig	2015-04-13 19:54:35.000000000 +0000
+++ modules/codec/x264.c
@@ -843,7 +843,7 @@ static int  Open ( vlc_object_t *p_this 
     fullrange = var_GetBool( p_enc, SOUT_CFG_PREFIX "fullrange" );
     p_enc->fmt_in.i_codec = fullrange ? VLC_CODEC_J420 : VLC_CODEC_I420;
     p_sys->i_colorspace = X264_CSP_I420;
-#if X264_BUILD >= 118
+#if X264_BUILD >= 118 && X264_BUILD < 155
     char *psz_profile = var_GetString( p_enc, SOUT_CFG_PREFIX "profile" );
     if( psz_profile )
     {

This is much simpler.  Is it also wrong?  If so, do you have an
alternative?

-- 
Roy Bixler <rcbixler%nyx.net@localhost>
"The fundamental principle of science, the definition almost, is this: the
sole test of the validity of any idea is experiment."
-- Richard P. Feynman