Re: pkg/53347: devel/cmake fails to build

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/53347; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53347: devel/cmake fails to build
Date: Thu, 07 Jun 2018 13:11:09 +0200

 Hello John,
 
 john%ziaspace.com@localhost writes:
 > >Number:         53347
 > >Category:       pkg
 > >Synopsis:       devel/cmake fails to build
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       medium
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Wed Jun 06 21:20:00 +0000 2018
 > >Originator:     John Klos
 > >Release:        NetBSD 8.0_BETA
 > >Organization:
 > 	=
 
 > >Environment:
 > [...]
 > >Description:
 > 	=
 
 > Running pkg_rolling-replace fails with:
 >
 > =3D> Applying pkgsrc patches for cmake-3.11.3
 > =3D=3D=3D> wrapper-message [cmake-3.11.3] =3D=3D=3D> Creating toolchain =
 wrappers for cmake-3.11.3
 > sed: unknown option -- b
 > Usage:  sed [-aElnru] command [file ...]
 >         sed [-aElnru] [-e command] [-f command_file] [-I[extension]]
 >             [-i[extension]] [file ...]
 > *** Error code 1
 >
 > Stop.
 > make[1]: stopped in /usr/pkgsrc/devel/cmake
 > *** Error code 1
 >
 >
 > Running make in devel/cmake after the first failure succeeds.
 > [...]
 
 I do not think that this is a cmake problem but probably a regression
 of `-r1.7 pkgsrc/archivers/libarchive/builtin.mk' because sed commands
 are not properly quoted, and, at least the last one, contains whitespace
 and can be problematic.
 
 I think that the following patch will fix the issue:
 
  <https://www.NetBSD.org/~leot/pkgsrc-patches/libarchive-fake-pc-sed-quote=
 .patch>
 
 Can you please test it and let us known if it fixes the problem
 reported?
 
 
 Thank you!
 
 
 For completeness here the same patch inline:
 
 ------------------------ 8< ----------------- 8< ------------------------
 libarchive: Quote all sed commands in fake-libarchive-pc target
 
 At least the last `-e' contains whitespaces and can be problematic.
 Avoid that by quoting all commands.
 
 Should fix PR pkg/53347.
 
 Index: builtin.mk
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/archivers/libarchive/builtin.mk,v
 retrieving revision 1.7
 diff -u -p -r1.7 builtin.mk
 --- builtin.mk	6 Jun 2018 14:21:09 -0000	1.7
 +++ builtin.mk	7 Jun 2018 10:53:20 -0000
 @@ -113,12 +113,12 @@ fake-libarchive-pc:
  			${LN} -sf $${src} $${dst};					\
  		else									\
  			${ECHO_BUILDLINK_MSG} "Creating $${dst}";			\
 -			${SED}  -e s,@prefix@,${BUILDLINK_PREFIX.libarchive},		\
 -					-e s,@exec_prefix@,${BUILDLINK_PREFIX.libarchive},\
 -					-e s,@libdir@,${BUILDLINK_PREFIX.libarchive}/lib${LIBABISUFFIX},\
 -					-e s,@includedir@,${BUILDLINK_PREFIX.libarchive}/include,\
 -					-e s,@VERSION@,${BUILTIN_VERSION.libarchive},	\
 -					-e s,@LIBS@,-llzma -lbz2 -lz,			\
 +			${SED}  -e 's,@prefix@,${BUILDLINK_PREFIX.libarchive},'		\
 +					-e 's,@exec_prefix@,${BUILDLINK_PREFIX.libarchive},'\
 +					-e 's,@libdir@,${BUILDLINK_PREFIX.libarchive}/lib${LIBABISUFFIX},'\
 +					-e 's,@includedir@,${BUILDLINK_PREFIX.libarchive}/include,'\
 +					-e 's,@VERSION@,${BUILTIN_VERSION.libarchive},' \
 +					-e 's,@LIBS@,-llzma -lbz2 -lz,'			\
  				$${sedsrc} > $${dst};					\
  		fi									\
  	fi