pkg/53382: print/poppler: build is broken in FreeBSD 11.1-RELEASE

[santhosh.raju%gmail.com@localhost]

>Number:         53382
>Category:       pkg
>Synopsis:       print/poppler: build is broken in FreeBSD 11.1-RELEASE
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 18 04:10:00 +0000 2018
>Originator:     Santhosh Raju
>Release:        pkgsrc-current
>Organization:
>Environment:
FreeBSD fox.trouble.is 11.1-RELEASE-p10 FreeBSD 11.1-RELEASE-p10 #0: Tue May  8 05:21:56 UTC 2018     root%amd64-builder.daemonology.net@localhost:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
poppler fails to build via pkgsrc when run in FreeBSD 11.1-RELEASE. It fails with a message regarding a missing template.

Partial build output:

[ 86%] Building CXX object qt5/src/CMakeFiles/poppler-qt5.dir/ArthurOutputDev.cc.o
/usr/pkgsrc/print/poppler-qt5/work/poppler-0.64.0/qt5/src/ArthurOutputDev.cc:830:35: error: implicit instantiation of undefined template 'std::__1::array<double, 257>'                           std::array<double, maxSplits+1> ta;                                                                                                                                                                                             ^                                                                                                                                                             /usr/include/c++/v1/__tuple:222:64: note: template is declared here                                                                                                                             template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;

...

bmake[2]: stopped in /usr/pkgsrc/print/poppler/work/poppler-0.64.0
1 error
>How-To-Repeat:
1. Get current pkgsrc via CVS 
2. Prepare and bootstrap pkgsrc in FreeBSD 11.0-RELEASE
3. cd print/poppler && bmake
4. After sometime the build fails with the error mentioned in the "Full description"

>Fix:
Added the missing <array> header to prevent build breakages in FreeBSD 
11.1-RELEASE.

Steps to fix

1. Apply the following patch in print/poppler

--- qt5/src/ArthurOutputDev.h.orig      2018-06-17 16:29:27.452164000 +0000
+++ qt5/src/ArthurOutputDev.h
@@ -37,6 +37,9 @@
 #include <memory>
 #include <map>
 #include <stack>
+#if defined (__FreeBSD__)
+#include <array>
+#endif

 #include "goo/gtypes.h"
 #include "OutputDev.h"