pkg/53401: mail/sendmail build fails with OpenSSL 1.1 in -current

[jdbaker%mylinuxisp.com@localhost]

>Number:         53401
>Category:       pkg
>Synopsis:       mail/sendmail build fails with OpenSSL 1.1 in -current
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 27 02:05:00 +0000 2018
>Originator:     John D. Baker
>Release:        NetBSD/sparc-8.99.21, pkgsrc-HEAD (pre-pkgsrc-2018Q2)
>Organization:
>Environment:
NetBSD david.technoskunk.fur 8.99.21 NetBSD 8.99.21 (DAVID) #25: Tue Jun 26 13:37:45 CDT 2018  sysop%plex760.technoskunk.fur@localhost:/r0/build/current/obj/sparc/sys/arch/sparc/compile/DAVID sparc

>Description:
I last built "mail/sendmail" on this system exactly one year ago and
would have been none the wiser if my ISP had not started requiring
authentication for relay.

Setting about building with the "sasl" option enabled, the build
eventually failed in the stage-install phase with:

[...]
=> Checking file-check results for sendmail-8.15.2nb2
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg:
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/bin/hoststat
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/bin/mailq
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/bin/newaliases
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/bin/purgestat
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/libexec/sendmail/sendmail
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/man/man1/mailq.1
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/man/man1/newaliases.1
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/man/man5/aliases.5
ERROR:         /var/tmp/pkgsrc/mail/sendmail/work/.destdir/usr/pkg/man/man8/sendmail.8
*** Error code 1

Stop.
make[1]: stopped in /x/pkgsrc/mail/sendmail
*** Error code 1

Stop.
make: stopped in /x/pkgsrc/mail/sendmail


This is also seen in the bulk-build reports:

  http://mail-index.netbsd.org/pkgsrc-bulk/2018/06/05/msg016020.html
  http://mail-index.netbsd.org/pkgsrc-bulk/2018/06/23/msg016088.html

The actual error occurs much earlier, but the build continues
anyway:

[...]
cc -O -I. -I../../include -DNEWDB -DNIS -DMAP_REGEX -DSOCKETMAP -DLDAPMAP -D_FFR_LDAP_NETWORK_TIMEOUT -I/usr/pkg/include -DSMRSH_CMDDIR=\"/usr/pkg/libexec/sm.bin\" -DNETINET6 -DNEEDSGETIPNODE -DTCPWRAPPERS -DSASL=2 -DNAMED_RESN=0 -D_FFR_USE_GETPWNAM_ERRNO=1 -DMILTER -DSTARTTLS   -DLDAP_DEPRECATED -I/usr/include -I/usr/pkg/include -c tls.c
tls.c: In function 'get_dh512':
tls.c:70:4: error: dereferencing pointer to incomplete type 'DH {aka struct dh_st}'
  dh->p = BN_bin2bn(dh512_p, sizeof(dh512_p), NULL);
    ^~
tls.c: In function 'inittls':
tls.c:929:22: warning: implicit declaration of function 'BIO_s_file_internal' [-Wimplicit-function-declaration]
   crl_file = BIO_new(BIO_s_file_internal());
                      ^~~~~~~~~~~~~~~~~~~
tls.c:929:22: warning: passing argument 1 of 'BIO_new' makes pointer from integer without a cast [-Wint-conversion]
In file included from /usr/include/openssl/ssl.h:48:0,
                 from ./sendmail.h:125,
                 from tls.c:11:
/usr/include/openssl/bio.h:535:6: note: expected 'const BIO_METHOD * {aka const struct bio_method_st *}' but argument is of type 'int'
 BIO *BIO_new(const BIO_METHOD *type);
      ^~~~~~~
tls.c:1006:6: warning: 'RSA_generate_key' is deprecated [-Wdeprecated-declarations]
      (rsa_tmp = RSA_generate_key(RSA_KEYLENGTH, RSA_F4, NULL,
      ^
In file included from /usr/include/openssl/rsa.h:13:0,
                 from /usr/include/openssl/x509.h:31,
                 from /usr/include/openssl/ssl.h:50,
                 from ./sendmail.h:125,
                 from tls.c:11:
/usr/include/openssl/rsa.h:193:1: note: declared here
 DEPRECATEDIN_0_9_8(RSA *RSA_generate_key(int bits, unsigned long e, void
 ^
tls.c:1213:4: warning: 'DSA_generate_parameters' is deprecated [-Wdeprecated-declarations]
    dsa = DSA_generate_parameters(bits, NULL, 0, NULL,
    ^~~
In file included from /usr/include/openssl/dh.h:13:0,
                 from /usr/include/openssl/dsa.h:31,
                 from /usr/include/openssl/x509.h:32,
                 from /usr/include/openssl/ssl.h:50,
                 from ./sendmail.h:125,
                 from tls.c:11:
/usr/include/openssl/dsa.h:122:1: note: declared here
 DEPRECATEDIN_0_9_8(DSA *DSA_generate_parameters(int bits,
 ^
tls.c: In function 'tmp_rsa_key':
tls.c:1747:2: warning: 'RSA_generate_key' is deprecated [-Wdeprecated-declarations]
  rsa_tmp = RSA_generate_key(RSA_KEYLENGTH, RSA_F4, NULL, NULL);
  ^~~~~~~
In file included from /usr/include/openssl/rsa.h:13:0,
                 from /usr/include/openssl/x509.h:31,
                 from /usr/include/openssl/ssl.h:50,
                 from ./sendmail.h:125,
                 from tls.c:11:
/usr/include/openssl/rsa.h:193:1: note: declared here
 DEPRECATEDIN_0_9_8(RSA *RSA_generate_key(int bits, unsigned long e, void
 ^
tls.c: In function 'x509_verify_cb':
tls.c:1974:10: error: dereferencing pointer to incomplete type 'X509_STORE_CTX {aka struct x509_store_ctx_st}'
   if (ctx->error == X509_V_ERR_UNABLE_TO_GET_CRL)
          ^~
*** Error code 1

Stop.
make[1]: stopped in /var/tmp/pkgsrc/mail/sendmail/work/sendmail-8.15.2/obj.NetBSD.8.99.21.sparc/sendmail
[...]

>How-To-Repeat:
Build "mail/sendmail" on any -current system after the import of
OpenSSL v1.1.
>Fix: