Re: pkg/53436: firefox 61.0.1 build failure on NetBSD/i386 8.0_RC2

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR pkg/53436; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: jperkin%joyent.com@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: pkg/53436: firefox 61.0.1 build failure on NetBSD/i386 8.0_RC2
Date: Tue, 10 Jul 2018 00:38:49 +0900

 >  We used to see something similar on SunOS where i386 had stack
 >  protector issues whereas x86_64 was fine, until I applied this patch:
 >  
 >    https://github.com/joyent/pkgsrc/commit/10aee3e4aef98c2bd8512ef4cb4278d0c7102d13#diff-88dca29c55d4e66af367aeefadf55a7a
 >  
 >  Something similar might help you too.
 
 Thanks.
 
 I guess the following change pulled from NetBSD tree is more essencial:
  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/lang/gcc49/patches/patch-gcc_targhooks.c?rev=1.1&content-type=text/x-cvsweb-markup
 
 I'll apply it to gcc6 too.
 
 ---
 
 Note the following change also fixes the problem:
 
 $NetBSD$
 
 --- gcc/config/i386/i386.c.orig	2017-05-05 21:51:14.000000000 +0000
 +++ gcc/config/i386/i386.c
 @@ -48372,9 +48372,13 @@ ix86_mangle_type (const_tree type)
  static tree ATTRIBUTE_UNUSED
  ix86_stack_protect_fail (void)
  {
 +#if 0
    return TARGET_64BIT
  	 ? default_external_stack_protect_fail ()
  	 : default_hidden_stack_protect_fail ();
 +#else
 +  return default_external_stack_protect_fail ();
 +#endif
  }
  
  /* Select a format to encode pointers in exception handling data.  CODE
 
 ---
 Izumi Tsutsui