pkg/53527: syslogng does not compile

[kivinen%iki.fi@localhost]

>Number:         53527
>Category:       pkg
>Synopsis:       Trying to compile syslogng fails with error
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 15 17:50:00 +0000 2018
>Originator:     Tero Kivinen
>Release:        NetBSD 8.0_STABLE
>Organization:
IKI ry
>Environment:
System: NetBSD leimasin.iki.fi 8.0_STABLE NetBSD 8.0_STABLE (GENERIC) #0: Wed Aug 8 19:57:09 EEST 2018 kivinen%leimasin.iki.fi@localhost:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:

When trying to compile syslogng the compilation fails:

  CC       lib/compat/tests_loggen_libloggen_helper_la-openssl_support.lo
tests/loggen/loggen_helper.c:47:14: warning: implicit declaration of function 'socket' [-Wimplicit-function-declaration]
   int sock = socket(dest_addr->sa_family, sock_type, 0);
              ^
tests/loggen/loggen_helper.c:47:30: error: dereferencing pointer to incomplete type 'struct sockaddr'
   int sock = socket(dest_addr->sa_family, sock_type, 0);
                              ^
tests/loggen/loggen_helper.c:54:20: error: 'SOCK_STREAM' undeclared (first use in this function)
   if (sock_type == SOCK_STREAM)
                    ^
tests/loggen/loggen_helper.c:54:20: note: each undeclared identifier is reported only once for each function it appears in
tests/loggen/loggen_helper.c:63:7: warning: implicit declaration of function 'connect' [-Wimplicit-function-declaration]
   if (connect(sock, dest_addr, dest_addr_len) < 0)
       ^
tests/loggen/loggen_helper.c: In function 'connect_ip_socket':
tests/loggen/loggen_helper.c:90:32: error: 'AF_INET6' undeclared (first use in this function)
   hints.ai_family = use_ipv6 ? AF_INET6 : AF_INET;
                                ^
tests/loggen/loggen_helper.c:90:43: error: 'AF_INET' undeclared (first use in this function)
   hints.ai_family = use_ipv6 ? AF_INET6 : AF_INET;
                                           ^
tests/loggen/loggen_helper.c: In function 'connect_unix_domain_socket':
tests/loggen/loggen_helper.c:144:21: error: 'AF_UNIX' undeclared (first use in this function)
   saun.sun_family = AF_UNIX;
                     ^
  CC       tests/loggen/tests_loggen_libloggen_plugin_la-loggen_plugin.lo
gmake[2]: *** [Makefile:15111: tests/loggen/tests_loggen_libloggen_helper_la-loggen_helper.lo] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[1]: *** [Makefile:17933: all-recursive] Error 1
gmake: *** [Makefile:7334: all] Error 2
*** Error code 2

Stop.
make[2]: stopped in /usr/pkgsrc/sysutils/syslog-ng
*** Error code 1

Stop.
make[1]: stopped in /usr/pkgsrc/sysutils/syslog-ng
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/sysutils/syslog-ng
[1]    24717 exit 1     make update

I think this is because they do not include sys/socket.h. I tried to add 
the include to these test files, which allowed me to get through the compliation
but then the resulting binary did not work, it died immediately on start with 
unsupported syscall error or similar (I think it tried to call NetBSD 1.3 compat 
code for socket interfaces, so I assume there is some other includes missing).

>How-To-Repeat:

Check out sysutil/syslogng and say make update.

>Fix:

Not known. The reason I am trying to update syslogng, is that the previous
version died very quickly after boot because some syscall returned error 
which the syslogng considered fatal, and then it was stuck in busy loop.

The previous error could be seen as:

I/O error occurred while reading; fd='20', error='No buffer space available (55)'

appearing in the log and then syslogng was using 100% of one core after that. 
I am not sure if that issue has already been fixed by this version of syslogng
as I have not been able to get to that far yet.