pkg/53567: lang/erlang 21.0nb1 does not compile

[michael%emte.net.au@localhost]

>Number:         53567
>Category:       pkg
>Synopsis:       lang/erlang 21.0nb1 does not compile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 02 01:50:00 +0000 2018
>Originator:     Michael Taylor
>Release:        NetBSD 8.0
>Organization:
	
>Environment:
	
	
System: NetBSD dagonet.omniscient.local 8.0 NetBSD 8.0 (GENERIC) #0: Tue Jul 17 14:59:51 UTC 2018 mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/lto-wrapper
Target: x86_64--netbsd
Configured with: /usr/src/tools/gcc/../../external/gpl3/gcc.old/dist/configure --target=x86_64--netbsd --enable-long-long --enable-threads --with-bugurl=http://www.NetBSD.org/Misc/send-pr.html --with-pkgversion='NetBSD nb1 20171112' --with-system-zlib --disable-libstdcxx-dual-abi --enable-__cxa_atexit --enable-libstdcxx-time=rt --enable-libstdcxx-threads --with-tune=nocona --with-diagnostics-color=auto-if-env --with-mpc-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/mpc/lib/libmpc --with-mpfr-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/mpfr/lib/libmpfr --with-gmp-lib=/var/obj/mknative/amd64-x86_64/usr/src/external/lgpl3/gmp/lib/libgmp --with-mpc-include=/usr/src/external/lgpl3/mpc/dist/src --with-mpfr-include=/usr/src/external/lgpl3/mpfr/dist/src --with-gmp-include=/usr/src/external/lgpl3/gmp/lib/libgmp/arch/x86_64 --enable-tls --disable-multilib --disable-symvers --disable-libstdcxx-pch --disable-libstdcxx-dual-abi --build=x86_64-unknown-netbsd7.1 --host=x86
 _64--netbsd --with-sysroot=/var/obj/mknative/amd64-x86_64/usr/src/destdir.amd64
Thread model: posix
gcc version 5.5.0 (nb2 20180327)

$ pwd
/usr/pkgsrc/lang/erlang
$ cvs ls -l
---- 2003-04-30 09:47:45 +1000 1.1.1.1    DESCR
---- 2007-07-29 00:27:09 +1000 1.1        MESSAGE
---- 2018-08-22 19:45:19 +1000 1.87       Makefile
---- 2018-07-03 21:01:21 +1000 1.32       Makefile.versions
---- 2018-07-03 21:01:21 +1000 1.31       PLIST
---- 2015-09-13 18:11:09 +1000 1.1        PLIST.Darwin
---- 2015-12-20 23:39:30 +1100 1.1        PLIST.FreeBSD
---- 2012-01-24 14:39:22 +1100 1.1        PLIST.Linux
---- 2015-07-25 22:13:53 +1000 1.1        PLIST.NetBSD
---- 2009-12-15 23:09:20 +1100 1.1        PLIST.SunOS
---- 2018-07-03 21:01:21 +1000 1.6        PLIST.hipe
---- 2018-07-03 21:01:21 +1000 1.12       PLIST.java
---- 2015-07-18 18:55:16 +1000 1.14       buildlink3.mk
---- 2018-08-15 04:40:42 +1000 1.60       distinfo
---- 2015-04-29 00:34:20 +1000 1.2        hacks.mk
---- 2017-04-14 04:24:45 +1000 1.2        module.mk
---- 2016-12-18 00:06:18 +1100 1.9        options.mk
---- 2018-07-03 21:01:21 +1000 1.1        versions.mk
d--- 2018-09-01 23:52:00 +1000            files
d--- 2018-09-01 23:52:00 +1000            patches

>Description:

Compile of lang/erlang 21.0nb1 fails with
>  LD     /data/pkgsrc/work/lang/erlang/work/otp_src_21.0/bin/x86_64-unknown-netbsd8.0/beam.prof.smp
> ld: __gcov_indirect_call_callee: TLS reference in obj/x86_64-unknown-netbsd8.0/opt/smp/beam_emu_pg.o mismatches non-TLS reference in /usr/lib/libgcov.a(_gcov_indirect_call_profiler_v2.o)
> /usr/lib/libgcov.a: error adding symbols: Bad value

>How-To-Repeat:

$ cd /usr/pkgsrc/lang/erlang
$ make

>Fix:

I was able to complete the compile with the following patch.

$ cvs diff Makefile
Index: Makefile
===================================================================
RCS file: /mirror/pkgsrc/lang/erlang/Makefile,v
retrieving revision 1.87
diff -r1.87 Makefile
24a25
> CONFIGURE_ARGS+=        --disable-pgo

Someone with better knowledge of pgo and tls may be able to resolve the compile
error rather than just avoiding it.

>Unformatted: