pkg/53571: lang/erlang 21.0nb1 fails PLIST file-check

[michael%emte.net.au@localhost]

>Number:         53571
>Category:       pkg
>Synopsis:       lang/erlang 21.0nb1 fails PLIST file-check
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 03 06:20:00 +0000 2018
>Originator:     Michael Taylor
>Release:        NetBSD 8.0
>Organization:
>Environment:
System: NetBSD dagonet.omniscient.local 8.0 NetBSD 8.0 (GENERIC) #0: Tue Jul 17 14:59:51 UTC 2018 mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64

>Description:

make package fails with:
> => Checking file-check results for erlang-21.0nb1
> ERROR: ************************************************************
> ERROR: The following files are in the PLIST but not in /data/pkgsrc/work/lang/erlang/work/.destdir/usr/pkg:
> ERROR:         /data/pkgsrc/work/lang/erlang/work/.destdir/usr/pkg/lib/erlang/lib/os_mon-2.4.5/priv/bin/ferrule
> ERROR:         /data/pkgsrc/work/lang/erlang/work/.destdir/usr/pkg/lib/erlang/lib/os_mon-2.4.5/priv/bin/mod_syslog
> ERROR:         /data/pkgsrc/work/lang/erlang/work/.destdir/usr/pkg/lib/erlang/lib/os_mon-2.4.5/src/ferrule.c
> ERROR:         /data/pkgsrc/work/lang/erlang/work/.destdir/usr/pkg/lib/erlang/lib/os_mon-2.4.5/src/mod_syslog.c

>How-To-Repeat:

Apply patch suggested in pkg/53567 to ensure compile succeeds.

$ cd /usr/pkgsrc/lang/erlang
$ cvs ls -l
---- 2003-04-30 09:47:45 +1000 1.1.1.1    DESCR
---- 2007-07-29 00:27:09 +1000 1.1        MESSAGE
---- 2018-08-22 19:45:19 +1000 1.87       Makefile
---- 2018-07-03 21:01:21 +1000 1.32       Makefile.versions
---- 2018-07-03 21:01:21 +1000 1.31       PLIST
---- 2015-09-13 18:11:09 +1000 1.1        PLIST.Darwin
---- 2015-12-20 23:39:30 +1100 1.1        PLIST.FreeBSD
---- 2012-01-24 14:39:22 +1100 1.1        PLIST.Linux
---- 2015-07-25 22:13:53 +1000 1.1        PLIST.NetBSD
---- 2009-12-15 23:09:20 +1100 1.1        PLIST.SunOS
---- 2018-07-03 21:01:21 +1000 1.6        PLIST.hipe
---- 2018-07-03 21:01:21 +1000 1.12       PLIST.java
---- 2015-07-18 18:55:16 +1000 1.14       buildlink3.mk
---- 2018-08-15 04:40:42 +1000 1.60       distinfo
---- 2015-04-29 00:34:20 +1000 1.2        hacks.mk
---- 2017-04-14 04:24:45 +1000 1.2        module.mk
---- 2016-12-18 00:06:18 +1100 1.9        options.mk
---- 2018-07-03 21:01:21 +1000 1.1        versions.mk
d--- 2018-09-01 23:52:00 +1000            files
d--- 2018-09-01 23:52:00 +1000            patches
$ make package

>Fix:

The following patch allows `make package` to complete successfully.

$ cvs diff PLIST
Index: PLIST
===================================================================
RCS file: /mirror/pkgsrc/lang/erlang/PLIST,v
retrieving revision 1.31
diff -r1.31 PLIST
2008d2007
< lib/erlang/lib/os_mon-${VERSION.os_mon}/priv/bin/ferrule
2010d2008
< lib/erlang/lib/os_mon-${VERSION.os_mon}/priv/bin/mod_syslog
2015d2012
< lib/erlang/lib/os_mon-${VERSION.os_mon}/src/ferrule.c
2019d2015
< lib/erlang/lib/os_mon-${VERSION.os_mon}/src/mod_syslog.c

This matches with erts/configure.in in the Erlang OTP source only building
ferrule and mod_syslog for $host_os matching solaris2*

Note, the lines removed are already present in PLIST.SunOS