pkg/53579: devel/libidn needs to be updated to 1.34 for gcc 7+

[davshao%gmail.com@localhost]

>Number:         53579
>Category:       pkg
>Synopsis:       devel/libidn needs to be updated to 1.34 for gcc 7+
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 06 14:45:00 +0000 2018
>Originator:     David Shao
>Release:        pkgsrc current cvs
>Organization:
>Environment:
DragonFly  5.3-DEVELOPMENT DragonFly v5.3.0.18522.g9b5eb-DEVELOPMENT #0: Thu Sep  6 00:59:37 PDT 2018     xxxxxx@:/usr/obj/usr/src/sys/X86_64_GENERIC  x86_64
>Description:
DragonFly 5.3-DEVELOPMENT recently changed to gcc 8 as the default compiler:

$ gcc --version
gcc 8.1 [DragonFly] Release/2018-05-02

Compiling devel/libidn results in

  CC       strerror.lo
In file included from strerror.c:28:
intprops.h:234:33: error: expected ')' before '(' token
    __builtin_add_overflow (a, b, (__typeof__ ((a) + (b)) *) 0)
                                 ^~
                                 )
strerror.c: In function 'rpl_strerror':
strerror.c:44:21: warning: implicit declaration of function 'strerror_override'; did you mean 'strerror_r'? [-Wimplicit-function-declaration]
   const char *msg = strerror_override (n);
                     ^~~~~~~~~~~~~~~~~
                     strerror_r
strerror.c:44:21: warning: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]

>How-To-Repeat:

>Fix:
FreeBSD ports / DragonFly dports have already upgraded to libidn 1.34.

From its release announcement:

https://lists.gnu.org/archive/html/info-gnu/2018-04/msg00001.html

** build: Fix build for gcc-7

diff -x CVS -Nur devel/libidn.orig/Makefile devel/libidn/Makefile
--- devel/libidn.orig/Makefile	2018-08-22 22:13:30.000000000 -0700
+++ devel/libidn/Makefile	2018-09-06 07:24:30.269425000 -0700
@@ -1,6 +1,6 @@
 # $NetBSD: Makefile,v 1.99 2018/08/22 09:43:32 wiz Exp $
 
-DISTNAME=	libidn-1.33
+DISTNAME=	libidn-1.34
 PKGREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	ftp://alpha.gnu.org/pub/gnu/libidn/
diff -x CVS -Nur devel/libidn.orig/PLIST devel/libidn/PLIST
--- devel/libidn.orig/PLIST	2015-03-06 22:41:23.000000000 -0800
+++ devel/libidn/PLIST	2018-09-06 07:31:47.369690000 -0700
@@ -77,6 +77,7 @@
 share/locale/pt_BR/LC_MESSAGES/libidn.mo
 share/locale/ro/LC_MESSAGES/libidn.mo
 share/locale/sr/LC_MESSAGES/libidn.mo
+share/locale/sv/LC_MESSAGES/libidn.mo
 share/locale/uk/LC_MESSAGES/libidn.mo
 share/locale/vi/LC_MESSAGES/libidn.mo
 share/locale/zh_CN/LC_MESSAGES/libidn.mo
diff -x CVS -Nur devel/libidn.orig/distinfo devel/libidn/distinfo
--- devel/libidn.orig/distinfo	2016-07-21 06:35:03.000000000 -0700
+++ devel/libidn/distinfo	2018-09-06 07:24:50.999719000 -0700
@@ -1,7 +1,7 @@
 $NetBSD: distinfo,v 1.63 2016/07/21 11:51:28 wiz Exp $
 
-SHA1 (libidn-1.33.tar.gz) = 57872fdc665dcc585e16f4ac0bb35374b1103f7e
-RMD160 (libidn-1.33.tar.gz) = b6bff80e6d5b5e3ee15a52378d42c7b9074a627d
-SHA512 (libidn-1.33.tar.gz) = 38dd459eaeda0c9e3cc2d24d967113515a499747550a2a9157f32357def90d71a3a3b52398e96a44a28cd5948dc353b0473c4ff0453a69720191c4cb49cac2c6
-Size (libidn-1.33.tar.gz) = 3501056 bytes
+SHA1 (libidn-1.34.tar.gz) = 8701e3d01df25431802ce483756ecad698156835
+RMD160 (libidn-1.34.tar.gz) = 0d5184cf5a3bd3bcd65fb037b248cf9105c8aeb5
+SHA512 (libidn-1.34.tar.gz) = 1a9b5f2554d3953591b92010fa0fdedc438ca8bc31d2bc06c621eb5d423e81656607f09ac75bb02e1a5420459f69e82b5fb82987afa50db69793f9cd7a08365a
+Size (libidn-1.34.tar.gz) = 3691634 bytes
 SHA1 (patch-aa) = 569ffa945fb8f1aef509db6bcadbe1e63ba5df87