Re: pkg/53613: New package: audio/alure-1.2

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/53613; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53613: New package: audio/alure-1.2
Date: Tue, 25 Sep 2018 12:45:23 +0200

 Hello Bastian,
 
 Bastian Germann writes:
 > In the submitted version the buildlink3 is aware of the options. You can
 > check that with wip/gambas3-gb-openal.
 
 Sorry, I don't follow.  wip/gambas3-gb-openal seems to include alure
 bl3 and that's okay if alure was built with the default package
 options, but (maybe!) can be problematic if alure was built with
 non-default (extra) options.
 
 What I meant is, should audio/alure/buildlink3.mk be adjusted like that:
 
 Index: buildlink3.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/audio/alure/buildlink3.mk,v
 retrieving revision 1.1
 diff -u -p -r1.1 buildlink3.mk
 --- buildlink3.mk	21 Sep 2018 13:24:34 -0000	1.1
 +++ buildlink3.mk	25 Sep 2018 10:43:56 -0000
 @@ -8,6 +8,33 @@ ALURE_BUILDLINK3_MK:=
  BUILDLINK_API_DEPENDS.alure+=	alure>=1.2
  BUILDLINK_PKGSRCDIR.alure?=	../../audio/alure
  
 +pkgbase := alure
 +.include "../../mk/pkg-build-options.mk"
 +
 +.if !empty(PKG_BUILD_OPTIONS.alure:Mflac)
 +.include "../../audio/flac/buildlink3.mk"
 +.endif
 +
 +.if !empty(PKG_BUILD_OPTIONS.alure:Mfluidsynth)
 +.include "../../audio/fluidsynth/buildlink3.mk"
 +.endif
 +
 +.if !empty(PKG_BUILD_OPTIONS.alure:Mmodplug)
 +.include "../../audio/libmodplug/buildlink3.mk"
 +.endif
 +
 +.if !empty(PKG_BUILD_OPTIONS.alure:Msndfile)
 +.include "../../audio/libsndfile/buildlink3.mk"
 +.endif
 +
 +.if !empty(PKG_BUILD_OPTIONS.alure:Mvorbis)
 +.include "../../audio/libvorbis/buildlink3.mk"
 +.endif
 +
 +.if !empty(PKG_BUILD_OPTIONS.alure:Mmpg123)
 +.include "../../audio/mpg123/buildlink3.mk"
 +.endif
 +
  .include "../../audio/openal-soft/buildlink3.mk"
  .endif	# ALURE_BUILDLINK3_MK
  
 
 Thank you!