Re: pkg/53686: shells/pdksh building fails due to wrong preprocessor checking

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

The following reply was made to PR pkg/53686; it has been noted by GNATS.

From: "David H. Gutteridge" <david%gutteridge.ca@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/53686: shells/pdksh building fails due to wrong
 preprocessor checking
Date: Wed, 31 Oct 2018 20:54:09 -0400

 On Tue, 30 Oct 2018, at 05:50:49 +0100, Frédéric Fauberteau wrote:
 >It is a dependency for libuuid
 
 Well, my guesses were completely wrong, then. I've seen bash as a
 build requirement before, but never ksh. I looked at revision 1.3 of
 Makefile.common, and this dependency was introduced as a workaround
 for NetBSD 6. I reverted that change and tested on NetBSD 8, and the
 package compiled.
 
 Have you considered something more like this?
 
 --- Makefile.common.old 2018-09-29 20:21:11.781672810 -0400
 +++ Makefile.common     2018-10-31 20:40:52.949178690 -0400
 @@ -16,9 +16,7 @@
  
  USE_GCC_RUNTIME=       yes
  USE_LIBTOOL=           yes
 -USE_TOOLS+=            pkg-config ksh
 -# XXX PR pkg/52877 configure is broken on netbsd6
 -CONFIG_SHELL=          ksh
 +USE_TOOLS+=            pkg-config
  GNU_CONFIGURE=         yes
  CONFIGURE_ARGS+=       --disable-all-programs
  CONFIGURE_ARGS+=       --disable-bash-completion
 @@ -30,3 +28,11 @@
  CONFIGURE_ARGS+=       --disable-nls
  
  TEST_TARGET=           check
 +
 +.include "../../mk/bsd.fast.prefs.mk"
 +
 +# XXX PR pkg/52877: configure is broken on netbsd6
 +.if (${OPSYS} == "NetBSD" && !empty(OS_VERSION:M[0123456].*))
 +USE_TOOLS+=            ksh
 +CONFIG_SHELL=          ksh
 +.endif
 
 Dave