pkg/53747: PLIST.Darwin on x11/xinit patch

[louis%zabrico.com@localhost]

>Number:         53747
>Category:       pkg
>Synopsis:       PLIST.Darwin on x11/xinit patch
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 27 16:20:00 +0000 2018
>Originator:     Louis Guillaume
>Release:        pkgsrc-2018Q3 2018-11-26
>Organization:
>Environment:
Darwin dhcp-207.zabrico.com 18.2.0 Darwin Kernel Version 18.2.0: Fri Oct  5 19:41:49 PDT 2018; root:xnu-4903.221.2~2/RELEASE_X86_64 x86_64
>Description:
Install of x11/xinit fails during file-check:

=> Checking file-check results for xinit-1.4.0
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /opt/pkgobj/x11/xinit/work/.destdir/opt/pkg:
ERROR:         /opt/pkgobj/x11/xinit/work/.destdir/opt/pkg/share/examples/xinit/launchd_startx
ERROR:         /opt/pkgobj/x11/xinit/work/.destdir/opt/pkg/share/examples/xinit/privileged_startx
ERROR: ************************************************************
ERROR: The following files are in /opt/pkgobj/x11/xinit/work/.destdir/opt/pkg but not in the PLIST:
ERROR:         /opt/pkgobj/x11/xinit/work/.destdir/opt/pkg/libexec/launchd_startx
ERROR:         /opt/pkgobj/x11/xinit/work/.destdir/opt/pkg/libexec/privileged_startx
*** Error code 1
>How-To-Repeat:
Install x11/xinit from pkgsrc-2018Q3 on Darwin 18 (Mojave) and earlier versions as well. I noticed there is no difference with -current so the problem is likely to be there too.

I had noticed this before and reported it here...

https://mail-index.netbsd.org/pkgsrc-users/2018/05/02/msg026588.html

The patch below gets the package to build and it works, but I'm not sure if there was some intention to get startx and privileged_startx into share/examples, and that is not fixed with the patch.
>Fix:
--- x11/xinit/PLIST.Darwin.orig 2018-11-27 10:05:54.317064617 -0500
+++ x11/xinit/PLIST.Darwin      2018-11-27 10:05:59.858129526 -0500
@@ -3,8 +3,8 @@
 bin/xinit
 man/man1/startx.1
 man/man1/xinit.1
-share/examples/xinit/launchd_startx
-share/examples/xinit/privileged_startx
+libexec/launchd_startx
+libexec/privileged_startx
 share/examples/xinit/privileged_startx.d/10-tmpdirs
 share/examples/xinit/privileged_startx.d/20-font_cache
 share/examples/xinit/xinitrc