pkg/53766: pkgsrc/mail/mailsend fails install with csh-type shells

[scole_mail%gmx.com@localhost]

>Number:         53766
>Category:       pkg
>Synopsis:       pkgsrc/mail/mailsend fails install with csh-type shells
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Dec 07 17:25:00 +0000 2018
>Originator:     scole_mail
>Release:        pkgsrc-2018Q3
>Organization:
none
>Environment:
NetBSD dstar 8.0_STABLE NetBSD 8.0_STABLE (GENERIC) #0: Fri Nov 30 13:53:15 PST 2018  scole@dstar:/home/scole/nbsd/cvs/8_0/obj/sys/arch/i386/compile/GENERIC i386
>Description:
pkgsrc/mail/mailsend won't install if the users shell is t/csh.

At the install stage, it looks like it is calling a install script "mkinstalldirs" with the users $SHELL variable, and mkinstalldirs is a bash-type shell

===> Installing for mailsend-1.19
=> Generating pre-install file lists
/bin/tcsh ./mkinstalldirs /usr/pkgsrc/mail/mailsend/work/.destdir/usr/pkg/bin
errstatus=0: Command not found.
for: Command not found.
do: Command not found.
set: Variable name must begin with a letter.
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/mail/mailsend/work/mailsend-1.19
*** Error code 1

Stop.
bmake[1]: stopped in /usr/pkgsrc/mail/mailsend
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/mail/mailsend

>How-To-Repeat:
cd .../pkgsrc/mail/mailsend && bmake install
>Fix:
I'm not sure of the proper way, but this change worked for me.

Summary of changes:  (A/? = New, R/D = Removed, M = Modified)
=============================================================
M Makefile

Apply patch with "cd .../pkgsrc/mail/mailsend ; patch -s -p0 < .../patchfile"

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/mail/mailsend/Makefile,v
retrieving revision 1.1
diff -b -u -r1.1 Makefile
--- Makefile    17 Jul 2017 16:09:38 -0000      1.1
+++ Makefile    7 Dec 2018 17:20:42 -0000
@@ -2,6 +2,7 @@
 #
 
 DISTNAME=      mailsend-1.19
+PKGREVISION=   1
 CATEGORIES=    mail
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=muquit/}
 GITHUB_TAG=    ${PKGVERSION_NOREV}
@@ -14,4 +15,7 @@
 
 GNU_CONFIGURE=         yes
 
+MAKE_ENV+=     SHELL=${TOOLS_PATH.bash}
+USE_TOOLS+=    bash
+
 .include "../../mk/bsd.pkg.mk"