pkg/53828: www/firefox version 64.0 doesn't build on i386

[scole_mail%gmx.com@localhost]

>Number:         53828
>Category:       pkg
>Synopsis:       www/firefox version 64.0 doesn't build on i386
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 02 17:20:00 +0000 2019
>Originator:     scole_mail
>Release:        pkgsrc-2018Q4
>Organization:
none
>Environment:
NetBSD dstar 8.0_STABLE NetBSD 8.0_STABLE (GENERIC) #0: Fri Nov 30 13:53:15 PST 2018  scole@dstar:/home/scole/nbsd/cvs/8_0/obj/sys/arch/i386/compile/GENERIC i386
>Description:
firefox 64.0 doesn't build on i386.  It is pulling in .../lang/nodejs as a tool dependency and that will fail compilation.  It seems like nodejs is looking for an BSD i386 assembly opensslconf.h that doesn't exist:

  cc -o /usr/pkgsrc/lang/nodejs/work/node-v10.14.2/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/bio_ssl.o ../deps/openssl/openssl/ssl/bio_ssl.c '-DOPENSSL_NO_HW' '-DDSO_DLFCN' '-DHAVE_DLFCN_H' '-DNDEBUG' '-DOPENSSL_THREADS' '-DOPENSSL_NO_DYNAMIC_ENGINE' '-DOPENSSL_PIC' '-DOPENSSL_BN_ASM_PART_WORDS' '-DOPENSSL_IA32_SSE2' '-DOPENSSL_BN_ASM_MONT' '-DOPENSSL_BN_ASM_GF2m' '-DSHA1_ASM' '-DSHA256_ASM' '-DSHA512_ASM' '-DRC4_ASM' '-DMD5_ASM' '-DRMD160_ASM' '-DAES_ASM' '-DVPAES_ASM' '-DWHIRLPOOL_ASM' '-DGHASH_ASM' '-DECP_NISTZ256_ASM' '-DPADLOCK_ASM' '-DPOLY1305_ASM' '-DOPENSSLDIR="/etc/ssl"' '-DENGINESDIR="/dev/null"' '-DTERMIOS' -I/usr/pkg/include -I../deps/openssl/openssl -I../deps/openssl/openssl/include -I../deps/openssl/openssl/crypto -I../deps/openssl/openssl/crypto/include -I../deps/openssl/openssl/crypto/modes -I../deps/openssl/config -I../deps/openssl/config/archs/linux-elf/asm -I../deps/openssl/config/archs/linux-elf/asm/include -I../deps/openssl/config/archs/linux-elf/as
 m/crypto -I../deps/openssl/config/archs/linux-elf/asm/crypto/include/internal  -pthread -Wall -Wextra -Wno-unused-parameter -m32 -Wall -O3 -pthread -DL_ENDIAN -fomit-frame-pointer -Wno-missing-field-initializers -Wno-old-style-declaration -O3 -fno-omit-frame-pointer  -MMD -MF /usr/pkgsrc/lang/nodejs/work/node-v10.14.2/out/Release/.deps//usr/pkgsrc/lang/nodejs/work/node-v10.14.2/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/bio_ssl.o.d.raw -I/usr/include -I/usr/pkg/include -O2 -D_FORTIFY_SOURCE=2 -pthread -I/usr/include -I/usr/pkg/include -c
In file included from ../deps/openssl/openssl/include/../../config/opensslconf.h:9:0,
                 from ../deps/openssl/openssl/include/openssl/opensslconf.h:1,
                 from ../deps/openssl/openssl/include/openssl/e_os2.h:13,
                 from ../deps/openssl/openssl/include/openssl/crypto.h:22,
                 from ../deps/openssl/openssl/ssl/bio_ssl.c:14:
../deps/openssl/openssl/include/../../config/./opensslconf_asm.h:112:62: fatal error: ./archs/BSD-x86/asm/include/openssl/opensslconf.h: No such file or directory
compilation terminated.
gmake[1]: *** [deps/openssl/openssl.target.mk:804: /usr/pkgsrc/lang/nodejs/work/node-v10.14.2/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/bio_ssl.o] Error 1
rm efc2c5cce04a810e8ce35e955c6805eadadea2a0.intermediate 523fbd2ef271a08bc4faae8badc3e5917bee51ef.intermediate
gmake: *** [Makefile:99: node] Error 2
*** Error code 2

Stop.
bmake[2]: stopped in /usr/pkgsrc/lang/nodejs
*** Error code 1

Stop.
bmake[1]: stopped in /usr/pkgsrc/lang/nodejs
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/www/firefox


I don't believe pkgsrc-2018Q3/firefox 62.03 the dependency on nodejs. I tried disabling nodejs by modifying www/firefox/mozilla-common.mk to

 .if ${MACHINE_ARCH} == "sparc64" || ${MACHINE_ARCH} == "i386"
 CONFIGURE_ARGS+=        --disable-nodejs
 .else
 TOOL_DEPENDS+=          nodejs-[0-9]*:../../lang/nodejs
 .endif

but that also failed compilation with an error about nodejs being needed.

>How-To-Repeat:
cd .../pkgsrc/www/firefox && bmake
>Fix: