Re: pkg/53787: Update devel/lua-filesytem to 1.7.0

Hello Leonardo,

I have reworked the patch to avoid using pkg-config, not sure it's better this way though.

Also put some comments in the patches

The changelog :

Version 1.7.0 [15/Sep/2017]

symlinkattributes function now provides 'target' field, containing name of the file that the symlink points to.
attributes, symlinkattributes, touch, mkdir, and rmdir functions now return system-dependent error code as the third value on error.
Fixed detection of closed files for Lua 5.2+ in setmode, lock, and unlock functions.
Fixed various compiler warnings.

Sorry for the late reply.

Thank you,

Le sam. 15 déc. 2018 à 19:00, Leonardo Taccari <leot%netbsd.org@localhost> a écrit :

The following reply was made to PR pkg/53787; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc:
Subject: Re: pkg/53787: Update devel/lua-filesytem to 1.7.0_2
Date: Sat, 15 Dec 2018 11:57:51 +0100

Hello Jonathan,

jonthn+pkgsrc%pinacea.com@localhost writes:
> [...]
> I tried to contact the maintainer 'filip' but this mailbox doesn't exist anymore.
>
> See this diff to update to latest (only tested on macOS)
> [...]

Thank you for the PR and patch!

Just some possible comments directly inline!

> +$NetBSD$
> +
> +--- Makefile.orig 2018-12-15 04:00:31.000000000 +0000
> ++++ Makefile
> +@@ -12,7 +12,7 @@ OBJS= src/$T.o
> + lib: src/lfs.so
> +
> + src/lfs.so: $(OBJS)
> +- MACOSX_DEPLOYMENT_TARGET="10.3"; export MACOSX_DEPLOYMENT_TARGET; $(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
> ++ $(CC) $(LIB_OPTION) -o src/lfs.so $(OBJS)
> +
> + test: lib
> + LUA_CPATH=./src/?.so lua tests/test.lua

Why is it needed to remove MACOSX_DEPLOYMENT_TARGET?
(please add comment to patch)

> diff --git c/devel/lua-filesystem/patches/patch-aa i/devel/lua-filesystem/patches/patch-config
> similarity index 66%
> rename from devel/lua-filesystem/patches/patch-aa
> rename to devel/lua-filesystem/patches/patch-config
> index 9dc3373d6f8..bb0a27b5440 100644
> --- c/devel/lua-filesystem/patches/patch-aa
> +++ i/devel/lua-filesystem/patches/patch-config
> [...]
> -@@ -16,7 +16,7 @@ LIB_OPTION= -shared #for Linux
> +
> + # OS dependent
> +-LIB_OPTION= -shared #for Linux
> +-#LIB_OPTION= -bundle -undefined dynamic_lookup #for MacOS X
> ++LIB_OPTION+= $(shell pkg-config --libs lua-${LUA_LINKVERSION}) -shared #for Linux
> ++#LIB_OPTION+= -bundle -undefined dynamic_lookup #for MacOS X
> +
> LIBNAME= $T.so.$V
>
> # Compilation directives
>

Why is it needed to adjust LIB_OPTION?
(please add comment to this hunk of patch)

If this in not needed the `pkg-config' from USE_TOOLS can be removed
and also exporting LUA_LINKVERSION via MAKE_ENV.

(If you can please also provide a changelog for the update, thanks!)

Thank you again!