Re: pkg/53859: pkgsrc-2018Q4 musicpd needs GCC 6

[triaxx <triaxx%triaxx.org@localhost>]

Le 2019-01-10 23:25, Simon Burge a écrit :
> > Number:         53859
> > Category:       pkg
> > Synopsis:       pkgsrc-2018Q4 musicpd needs GCC 6
> > Confidential:   no
> > Severity:       non-critical
> > Priority:       low
> > Responsible:    pkg-manager
> > State:          open
> > Class:          sw-bug
> > Submitter-Id:   net
> > Arrival-Date:   Thu Jan 10 22:25:00 +0000 2019
> > Originator:     Simon Burge
> > Release:        NetBSD 8.0 and pkgsrc-2018Q4
> > Organization:
> Disorganised
> > Environment:
> 	System: NetBSD thoreau.thistledown.com.au 8.0 NetBSD 8.0 (THOREAU)
> #6: Thu Sep 27 13:00:57 AEST 2018
> simonb%thoreau.thistledown.com.au@localhost:/NetBSD/src8/sys/arch/amd64/compile/THOREAU
> amd64
> Architecture: x86_64
> Machine: amd64
> > Description:
> 	Building the musicpd package from pkgsrc-2018Q4 on a NetBSD 8
> 	system gives the following error:
>
> ../src/util/Compiler.h:66:6: error: #error Sorry, your gcc version is
> too old. You need at
>  least version 6.0.
>  #    error Sorry, your gcc version is too old.  You need at least 
> version 6.0.
>       ^
> ninja: build stopped: subcommand failed.
>
> thoreau 37> grep GCC *
> Makefile:GCC_REQD+=             4.9
>
> > How-To-Repeat:
> 	On a NetBSD 8 system "cd .../pkgsrc/audio/musicpd; make"
> > Fix:
> 	Change GCC_REQD to "6" as per the patch below.  Note that
> 	on HEAD musicpd has been updated to a newer version and has
> 	this same GCC_REQD change.  The patch below is _only_ for
> 	pkgsrc-2018Q4.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/audio/musicpd/Makefile,v
> retrieving revision 1.178
> diff -d -p -u -r1.178 Makefile
> --- Makefile	13 Dec 2018 19:51:41 -0000	1.178
> +++ Makefile	10 Jan 2019 22:13:37 -0000
> @@ -22,7 +22,7 @@ USE_LANGUAGES=		c c++
>  MESON_ARGS+=		-Ddocumentation=true
>
>  # c++14
> -GCC_REQD+=		4.9
> +GCC_REQD+=		6
>
>  CPPFLAGS.SunOS+=	-std=gnu99 -D_XOPEN_SOURCE=600 -D__EXTENSIONS__

audio/musicpd has just been updated for 5 days as you can see:
$ cvs diff -r1.178 Makefile
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/musicpd/Makefile,v
retrieving revision 1.178
retrieving revision 1.179
diff -r1.178 -r1.179
1c1
< # $NetBSD: Makefile,v 1.178 2018/12/13 19:51:41 adam Exp $
---
> # $NetBSD: Makefile,v 1.179 2019/01/05 12:43:46 triaxx Exp $
3c3
< DISTNAME=             mpd-0.21.3
---
> DISTNAME=             mpd-0.21.4
5d4
< PKGREVISION=          1
25c24
< GCC_REQD+=            4.9
---
> GCC_REQD+=            6

It is now fixed.

Thanks Simon!