Re: pkg/53771: digest keccak.c does not compile on IRIX with mipspro compiler

[Alistair Crooks <agc%pkgsrc.org@localhost>]

The following reply was made to PR pkg/53771; it has been noted by GNATS.

From: Alistair Crooks <agc%pkgsrc.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/53771: digest keccak.c does not compile on IRIX with mipspro compiler
Date: Mon, 14 Jan 2019 20:36:03 -0800

 --000000000000960b3a057f77b312
 Content-Type: text/plain; charset="UTF-8"
 
 Any luck running the self-tests?
 
 On Mon, 10 Dec 2018 at 13:01, Alistair Crooks <agc%pkgsrc.org@localhost> wrote:
 
 > Can you try to run the self tests, please? (They're for SHA3, so quote
 > relevant): "digest -t"
 >
 > Thanks,
 > Alistair
 >
 > On Sun, 9 Dec 2018 at 22:57, <esp%iki.fi@localhost> wrote:
 >
 >> >Number:         53771
 >> >Category:       pkg
 >> >Synopsis:       digest keccak.c does not compile on IRIX with mipspro
 >> compiler
 >> >Confidential:   no
 >> >Severity:       non-critical
 >> >Priority:       medium
 >> >Responsible:    pkg-manager
 >> >State:          open
 >> >Class:          sw-bug
 >> >Submitter-Id:   net
 >> >Arrival-Date:   Mon Dec 10 06:45:00 +0000 2018
 >> >Originator:     Erno Palonheimo
 >> >Release:        current-20181201
 >> >Organization:
 >> >Environment:
 >> IRIX64 arpakuutio 6.5 07202013 IP30 mips
 >>
 >> >Description:
 >> keccak.c of digest package has this preprocessor macro:
 >>
 >> #define FOR5(X, STMT) do
 >>     \
 >> {
 >>      \
 >>         (X) = 0; (STMT);
 >>     \
 >>         (X) = 1; (STMT);
 >>     \
 >>         (X) = 2; (STMT);
 >>     \
 >>         (X) = 3; (STMT);
 >>     \
 >>         (X) = 4; (STMT);
 >>     \
 >> } while (0)
 >>
 >> It results in code that has a gcc-specific syntax and Mipspro won't
 >> compile it.
 >> >How-To-Repeat:
 >> Try to build digest on IRIX using Mipspro.
 >> >Fix:
 >> Discussion on Freenode #pkgsrc revealed that this could possibly be
 >> worked around by changing the (STMT) on the macro to {STMT} as suggested by
 >> Rhialto. I changed the file manually and at least the compiler compiled it
 >> and the digest command works now. If further help in testing this on IRIX
 >> is needed, I can run tests on the machine.
 >>
 >>
 
 --000000000000960b3a057f77b312
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: base64
 
 PGRpdiBkaXI9Imx0ciI+QW55IGx1Y2sgcnVubmluZyB0aGUgc2VsZi10ZXN0cz88L2Rpdj48YnI+
 PGRpdiBjbGFzcz0iZ21haWxfcXVvdGUiPjxkaXYgZGlyPSJsdHIiPk9uIE1vbiwgMTAgRGVjIDIw
 MTggYXQgMTM6MDEsIEFsaXN0YWlyIENyb29rcyAmbHQ7PGEgaHJlZj0ibWFpbHRvOmFnY0Bwa2dz
 cmMub3JnIj5hZ2NAcGtnc3JjLm9yZzwvYT4mZ3Q7IHdyb3RlOjxicj48L2Rpdj48YmxvY2txdW90
 ZSBjbGFzcz0iZ21haWxfcXVvdGUiIHN0eWxlPSJtYXJnaW46MHB4IDBweCAwcHggMC44ZXg7Ym9y
 ZGVyLWxlZnQ6MXB4IHNvbGlkIHJnYigyMDQsMjA0LDIwNCk7cGFkZGluZy1sZWZ0OjFleCI+PGRp
 diBkaXI9Imx0ciI+Q2FuIHlvdSB0cnkgdG8gcnVuIHRoZSBzZWxmIHRlc3RzLCBwbGVhc2U/IChU
 aGV5JiMzOTtyZSBmb3IgU0hBMywgc28gcXVvdGUgcmVsZXZhbnQpOiAmcXVvdDtkaWdlc3QgLXQm
 cXVvdDs8ZGl2Pjxicj48L2Rpdj48ZGl2PlRoYW5rcyw8L2Rpdj48ZGl2PkFsaXN0YWlyPC9kaXY+
 PC9kaXY+PGJyPjxkaXYgY2xhc3M9ImdtYWlsX3F1b3RlIj48ZGl2IGRpcj0ibHRyIj5PbiBTdW4s
 IDkgRGVjIDIwMTggYXQgMjI6NTcsICZsdDs8YSBocmVmPSJtYWlsdG86ZXNwQGlraS5maSIgdGFy
 Z2V0PSJfYmxhbmsiPmVzcEBpa2kuZmk8L2E+Jmd0OyB3cm90ZTo8YnI+PC9kaXY+PGJsb2NrcXVv
 dGUgY2xhc3M9ImdtYWlsX3F1b3RlIiBzdHlsZT0ibWFyZ2luOjBweCAwcHggMHB4IDAuOGV4O2Jv
 cmRlci1sZWZ0OjFweCBzb2xpZCByZ2IoMjA0LDIwNCwyMDQpO3BhZGRpbmctbGVmdDoxZXgiPiZn
 dDtOdW1iZXI6wqAgwqAgwqAgwqAgwqA1Mzc3MTxicj4NCiZndDtDYXRlZ29yeTrCoCDCoCDCoCDC
 oHBrZzxicj4NCiZndDtTeW5vcHNpczrCoCDCoCDCoCDCoGRpZ2VzdCBrZWNjYWsuYyBkb2VzIG5v
 dCBjb21waWxlIG9uIElSSVggd2l0aCBtaXBzcHJvIGNvbXBpbGVyPGJyPg0KJmd0O0NvbmZpZGVu
 dGlhbDrCoCDCoG5vPGJyPg0KJmd0O1NldmVyaXR5OsKgIMKgIMKgIMKgbm9uLWNyaXRpY2FsPGJy
 Pg0KJmd0O1ByaW9yaXR5OsKgIMKgIMKgIMKgbWVkaXVtPGJyPg0KJmd0O1Jlc3BvbnNpYmxlOsKg
 IMKgIHBrZy1tYW5hZ2VyPGJyPg0KJmd0O1N0YXRlOsKgIMKgIMKgIMKgIMKgIG9wZW48YnI+DQom
 Z3Q7Q2xhc3M6wqAgwqAgwqAgwqAgwqAgc3ctYnVnPGJyPg0KJmd0O1N1Ym1pdHRlci1JZDrCoCDC
 oG5ldDxicj4NCiZndDtBcnJpdmFsLURhdGU6wqAgwqBNb24gRGVjIDEwIDA2OjQ1OjAwICswMDAw
 IDIwMTg8YnI+DQomZ3Q7T3JpZ2luYXRvcjrCoCDCoCDCoEVybm8gUGFsb25oZWltbzxicj4NCiZn
 dDtSZWxlYXNlOsKgIMKgIMKgIMKgIGN1cnJlbnQtMjAxODEyMDE8YnI+DQomZ3Q7T3JnYW5pemF0
 aW9uOjxicj4NCiZndDtFbnZpcm9ubWVudDo8YnI+DQpJUklYNjQgYXJwYWt1dXRpbyA2LjUgMDcy
 MDIwMTMgSVAzMCBtaXBzPGJyPg0KPGJyPg0KJmd0O0Rlc2NyaXB0aW9uOjxicj4NCmtlY2Nhay5j
 IG9mIGRpZ2VzdCBwYWNrYWdlIGhhcyB0aGlzIHByZXByb2Nlc3NvciBtYWNybzo8YnI+DQo8YnI+
 DQojZGVmaW5lIEZPUjUoWCwgU1RNVCkgZG/CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
 oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBcPGJyPg0K
 e8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
 IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
 IMKgXDxicj4NCsKgIMKgIMKgIMKgIChYKSA9IDA7IChTVE1UKTvCoCDCoCDCoCDCoCDCoCDCoCDC
 oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
 oCDCoCBcPGJyPg0KwqAgwqAgwqAgwqAgKFgpID0gMTsgKFNUTVQpO8KgIMKgIMKgIMKgIMKgIMKg
 IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
 IMKgIMKgIFw8YnI+DQrCoCDCoCDCoCDCoCAoWCkgPSAyOyAoU1RNVCk7wqAgwqAgwqAgwqAgwqAg
 wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
 wqAgwqAgwqAgXDxicj4NCsKgIMKgIMKgIMKgIChYKSA9IDM7IChTVE1UKTvCoCDCoCDCoCDCoCDC
 oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC
 oCDCoCDCoCDCoCBcPGJyPg0KwqAgwqAgwqAgwqAgKFgpID0gNDsgKFNUTVQpO8KgIMKgIMKgIMKg
 IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
 IMKgIMKgIMKgIMKgIFw8YnI+DQp9IHdoaWxlICgwKTxicj4NCjxicj4NCkl0IHJlc3VsdHMgaW4g
 Y29kZSB0aGF0IGhhcyBhIGdjYy1zcGVjaWZpYyBzeW50YXggYW5kIE1pcHNwcm8gd29uJiMzOTt0
 IGNvbXBpbGUgaXQuPGJyPg0KJmd0O0hvdy1Uby1SZXBlYXQ6PGJyPg0KVHJ5IHRvIGJ1aWxkIGRp
 Z2VzdCBvbiBJUklYIHVzaW5nIE1pcHNwcm8uPGJyPg0KJmd0O0ZpeDo8YnI+DQpEaXNjdXNzaW9u
 IG9uIEZyZWVub2RlICNwa2dzcmMgcmV2ZWFsZWQgdGhhdCB0aGlzIGNvdWxkIHBvc3NpYmx5IGJl
 IHdvcmtlZCBhcm91bmQgYnkgY2hhbmdpbmcgdGhlIChTVE1UKSBvbiB0aGUgbWFjcm8gdG8ge1NU
 TVR9IGFzIHN1Z2dlc3RlZCBieSBSaGlhbHRvLiBJIGNoYW5nZWQgdGhlIGZpbGUgbWFudWFsbHkg
 YW5kIGF0IGxlYXN0IHRoZSBjb21waWxlciBjb21waWxlZCBpdCBhbmQgdGhlIGRpZ2VzdCBjb21t
 YW5kIHdvcmtzIG5vdy4gSWYgZnVydGhlciBoZWxwIGluIHRlc3RpbmcgdGhpcyBvbiBJUklYIGlz
 IG5lZWRlZCwgSSBjYW4gcnVuIHRlc3RzIG9uIHRoZSBtYWNoaW5lLjxicj4NCjxicj4NCjwvYmxv
 Y2txdW90ZT48L2Rpdj4NCjwvYmxvY2txdW90ZT48L2Rpdj4NCg==
 --000000000000960b3a057f77b312--