pkg/53958: cannot turn off OVERRIDE_GNU_CONFIG_SCRIPTS

[dholland%eecs.harvard.edu@localhost]

>Number:         53958
>Category:       pkg
>Synopsis:       cannot turn off OVERRIDE_GNU_CONFIG_SCRIPTS
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 08 00:50:00 +0000 2019
>Originator:     David Holland
>Release:        NetBSD 8.99.27 (20181205) pkgsrc 20190207
>Organization:
>Environment:
System: NetBSD macaran 8.99.27 NetBSD 8.99.27 (MACARAN) #50: Wed Dec 5 19:34:11 EST 2018 dholland@macaran:/usr/src/sys/arch/amd64/compile/MACARAN amd64
Architecture: x86_64
Machine: amd64
>Description:

mk/configure/configure.mk has a switch to turn on and off replacing
config.guess and config.sub: OVERRIDE_GNU_CONFIG_SCRIPTS. However, it
is tested with defined() and assigned unconditionally in
gnu-configure.mk, which is included immediately previously.

This is useless.

One needs this switch when building exotic toolchains (or the like)
that have custom patches to config.guess and config.sub: replacing
with the pkgsrc versions loses the patches and then the packages
involved can't configure as intended.

>How-To-Repeat:

>Fix:

Change it to test for yes or no. But this is kind of a can of worms --
should all the adjacent related variables be changed as well? And if
so, Someone(TM) needs to spend time tracking down all the uses to make
sure they set "yes" and not "#defined".