Re: pkg/54086: sysutils/u-boot-bananapi doesn't build with WRKOBJDIR

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/54086; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54086: sysutils/u-boot-bananapi doesn't build with WRKOBJDIR
Date: Sun, 7 Apr 2019 21:11:32 +0000

 On Sat, Apr 06, 2019 at 11:35:02PM +0000, Leonardo Taccari wrote:
  >  Doing a `tr ' ' '\n'' and diff(1)ing them shows that - apart the
  >  different paths used - but that should be okay - the with WRKOBJDIR case
  >  misses the following -I that is present in without WRKOBJDIR (when
  >  consumed by the wrappers, i.e. the `<.>' line):
  >  
  >   -I/disks/raid1/work/pkgsrc/pkgsrc/sysutils/u-boot-bananapi/work/u-boot-20=
  >  18.11/scripts/dtc/libfdt
  >  
  >  (But unfortunately I have no idea ATM why:
  >  
  >   -I/disks/raid1/work/wrkobjdir/sysutils/u-boot-bananapi/work/u-boot-2018.1=
  >  1/scripts/dtc/libfdt
  >  
  >  ...isn't passed to the wrappers as well, sorry.)
 
 The problem is that WRKOBJDIR is a symlink: it is both
 /disks/raid1/work/wrkobjdir and /home/takashi/wrkobjdir. Both paths
 appear in the build, and this confuses the wrappers, which only know
 about one of them.
 
 The wrappers could stand to be smarter about this, but there are
 various reasons it hasn't been done. In the meantime, set WRKOBJDIR to
 the expanded path without symlinks.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost