pkg/54107: pkgsrc-2019Q1/misc/fbreader doesn't build with newer compiler(s)

[bernhard%netmuc.net@localhost]

>Number:         54107
>Category:       pkg
>Synopsis:       pkgsrc-2019Q1/misc/fbreader doesn't build with newer compiler(s)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 08 20:35:00 +0000 2019
>Originator:     Bernhard Riedel
>Release:        pkgsrc-2019Q1 as of 2019-04-07
>Organization:
>Environment:
NetBSD tja.crg.de 8.99.36 NetBSD 8.99.36 (GENERIC) #0: Wed Apr  3 18:57:32 CEST 2019  root%wip.crg.de@localhost:/sdata/test-current-20190403000000Z/obj/amd64/sys/arch/amd64/compile/GENERIC amd64
>Description:
When trying to bmake build, fails in
$WRKDIR/fbreader-0.99.4/fbreader/src/formats/doc/OleStorage.cpp
with
OleStorage.cpp: In member function 'bool OleStorage::init(shared_ptr<ZLInputStream>, std::size_t)':
OleStorage.cpp:62:83: error: narrowing conversion of '208' from 'int' to 'char' inside { } [-Wnarrowing]
  static const char OLE_SIGN[] = {0xD0, 0xCF, 0x11, 0xE0, 0xA1, 0xB1, 0x1A, 0xE1, 0};
[...]
>How-To-Repeat:
bmake build with environment as above
>Fix:
New patch patch-fbreader_src_formats_doc_OleStorage.cpp

Replaces offending 0xVW ints with '\xVW' char literals

gzipped, base64 encoded:

H4sICP2mq1wCA3BhdGNoLWZicmVhZGVyX3NyY19mb3JtYXRzX2RvY19PbGVTdG9yYWdlLmNw
cACNUdtOAjEQfd5+xZiQANld2KJEXSThIhgTI4m8eQkp3VloUtpNWxRD+He7K+qb2odzZs5M
z6TT2j260fy6RsgDFpJxhDXuWIZcbJgEoRyu0FhYvoN1RqgVSOHQMGnBaWCvWmSAxuiqpLcO
tAKFb2iA600hpL/bIiSOY8iXBr2vaVvD27k2G+ZsO9O8PZM4d9qwFbZ4UbS81SroJLQTUxqf
JkA76RlNO91W8nUgLJGEYfhfUzIYQNy9jM4hrNCnS60l/HSlqVDCNeyaGcwWhTNXj3e3qtg6
AkHAJTLTaPbK2KDbGgW53wCWwoHEgXXMCe5frKwD7i1gdjdZzG9v7p9eoA/7ZHedRJDsxtMS
KS1xUinDKh5VSIeVXsaHHgn/dK0/e9t6BJ7H00+m9JMnR314zEdHpsNjvczLKRCIHBrWZWnq
v1fxTdHQEkfbPPoeFsFFE076kDRh//syPgCG8EchSwIAAA==

P.S.: Feedback to original authors probably doesn't make a lot of sense.
The newest versions 0.10.7 and 0.12.10 seem to have dropped .doc
 support.