pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
pkg/54119: is suzeif() an odd typo, or an un-prototyped function?
>Number: 54119
>Category: pkg
>Synopsis: suzeif() appears to be a typo in xentools411/patches/patch-.._ipxe_src_net_fcels.c
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri Apr 12 22:55:00 +0000 2019
>Originator: Greg A. Woods
>Release: NetBSD 8.99.32 (2019/01/31), pkgsrc-current 2019/04/12
>Organization:
Planix, Inc.; Kelowna, BC; Canada
>Environment:
System: NetBSD future 8.99.32 NetBSD 8.99.32 (XEN3_DOMU) #0: Mon Feb 4 15:01:05 PST 2019 woods@future:/build/woods/future/current-amd64-amd64-obj/building/work/woods/m-NetBSD-current/sys/arch/amd64/compile/XEN3_DOMU amd64
Architecture: x86_64
Machine: amd64
>Description:
I just happened to switch to the window building xendtools411 at
the right time to see the following warning scroll by:
net/fcels.c: In function 'fc_els_echo_rx_request':
net/fcels.c:1267:16: warning: implicit declaration of function 'suzeif' [-Wimplicit-function-declaration]
size_t plen = suzeif(*echo) + len - sizeof ( struct fc_echo_frame_header );
^~~~~~
I'm guessing this is a typo for "sizeof()" (a hand-shifted-left
error), though I cannot be 100% sure since oddly this doesn't
seem to have had any adverse affect on the build, which
completes with a package that installs A-OK.
I have not yet run the resulting package yet though.
On the other hand this seems to have been in place since the
original xentools411 as the line is introduced by a pkgsrc patch
(patches/patch-.._ipxe_src_net_fcels.c), and it's been there
since the inception of xentools411 on 2018-07-24.
I'm guessing the patched file is compiled as part of one of the
qemu firmware files, but why it didn't generate a link error
that should have halted the build I have no clue.
>How-To-Repeat:
capture stderr for a build of xentools411
>Fix:
Home |
Main Index |
Thread Index |
Old Index