pkg/54145: SUBST stage fix from post-patch to pre-configure breaks build

[makoto%ki.nu@localhost]

>Number:         54145
>Category:       pkg
>Synopsis:       SUBST stage fix from post-patch to pre-configure breaks build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 28 14:05:00 +0000 2019
>Originator:     Makoto Fujiwara
>Release:        NetBSD 8.99.37
>Organization:
	KINU Corporation
>Environment:
	
	
System: NetBSD CF-SX3 8.99.37 NetBSD 8.99.37 (GENERIC-no-SYNAPTICS) #0: Sat Apr 6 21:56:07 JST 2019 root@CF-SX3:/tmp/O/sys/arch/amd64/compile/GENERIC-no-SYNAPTICS amd64
Architecture: x86_64
Machine: amd64
>Description:
	This is from the discussion with @tristelo (of twitter).

	With the changes on 2018/07/04,
	    http://mail-index.netbsd.org/pkgsrc-changes/2018/07/04/msg177915.html
	SUBST_STAGE is changed from post-patch to pre-configure
	Generally, this change should be good, but for this case, it breaks
	the build. build log looks like as follows.
	-------------------------------------------
	Patching file util/compile using Plan A...
	Hunk #1 succeeded at 1.
	Hunk #2 succeeded at 16.
	Hunk #3 succeeded at 58.
	done
	===> Creating toolchain wrappers for wmii-3.9.2
	===> Building for wmii-3.9.2
	MAKE all libbio/
	sh: ../util/compile: not found
	*** Error code 127
	
	Stop.
	make[1]: stopped in /export/WRKOBJDIR/wm/wmii/work/wmii+ixp-3.9.2/libbio
	*** Error code 1
	-------------------------------------------
>How-To-Repeat:
	cd /usr/pkgsrc/wm/wmii;
	make clean && make package
>Fix:
	Either revert the changes or look for better resolution

Index: wm/wmii/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/wm/wmii/Makefile,v
retrieving revision 1.35
diff -u -r1.35 Makefile
--- wm/wmii/Makefile	4 Jul 2018 13:40:40 -0000	1.35
+++ wm/wmii/Makefile	28 Apr 2019 13:18:29 -0000
@@ -50,7 +50,7 @@
 LDFLAGS.SunOS+=		-lsocket -lnsl -liconv
 
 SUBST_CLASSES+=		vars
-SUBST_STAGE.vars=	pre-configure
+SUBST_STAGE.vars=	post-patch
 SUBST_FILES.vars=	util/compile
 SUBST_VARS.vars=	EGREP SED SH AWK
 

>Unformatted: