Re: pkg/54183: (devel/rubymine) install directory should not honor PKG_REVISION

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/54183; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/54183: (devel/rubymine) install directory should not honor PKG_REVISION
Date: Thu, 09 May 2019 15:50:35 +0200

 Hello Makoto,
 
 makoto%if.t.u-tokyo.ac.jp@localhost writes:
 > [...]
 > Index: devel/rubymine-bin/Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/devel/rubymine-bin/Makefile,v
 > retrieving revision 1.2
 > diff -u -r1.2 Makefile
 > --- devel/rubymine-bin/Makefile	25 Apr 2019 07:32:50 -0000	1.2
 > +++ devel/rubymine-bin/Makefile	9 May 2019 13:32:32 -0000
 > @@ -48,7 +48,7 @@
 >  	${SED} -e "s|@@IDEA_HOME@@|${PREFIX}/${PKGNAME}|g" \
 
 Doesn't that ${PKGNAME} occurency should be replaced as well?
 
 >  	${FILESDIR}/rubymine.desktop > \
 >  	${DESTDIR}${PREFIX}/share/applications/rubymine.desktop && \
 > -	pax -rw -pm * ${DESTDIR}${PREFIX}/${PKGNAME}
 > +	pax -rw -pm * ${DESTDIR}${PREFIX}/${PKGNAME_NOREV}
 >  
 >  .include "../../lang/python/application.mk"
 >  .include "../../mk/java-vm.mk"
 > [...]
 
 Apart possibly addressing the other ${PKGNAME} occurency that
 substitute @@IDEA_HOME@@ if needed... looks good, please commit!
 
 
 Thank you!