Re: pkg/54327: pulseaudio: invalid PLIST due to lirc on Arch Linux

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/54327; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/54327: pulseaudio: invalid PLIST due to lirc on Arch Linux
Date: Tue, 25 Jun 2019 10:29:40 +0200

 Hello Frédéric, 
 just a minor possible suggestion and a question,
 
 triaxx%NetBSD.org@localhost writes:
 > [...]
 > --- options.mk	25 Jul 2018 12:15:59 -0000	1.9
 > +++ options.mk	25 Jun 2019 07:06:07 -0000
 > @@ -1,7 +1,7 @@
 >  # $NetBSD: options.mk,v 1.9 2018/07/25 12:15:59 adam Exp $
 > 
 >  PKG_OPTIONS_VAR=       PKG_OPTIONS.pulseaudio
 > -PKG_SUPPORTED_OPTIONS= avahi fftw gsettings x11
 > +PKG_SUPPORTED_OPTIONS= avahi fftw gsettings lirc x11
 >  PKG_SUGGESTED_OPTIONS= avahi x11
 >  PLIST_VARS+=           ${PKG_SUPPORTED_OPTIONS}
 > [...] 
 > @@ -40,6 +33,23 @@
 > [...]
 > +.if !empty(PKG_OPTIONS:Mlirc)
 > +.include "../../comms/lirc/buildlink3.mk"
 > +.  if ${LIRC_AVAILABLE} == "yes"
 > +PLIST.lirc=		yes
 > +CONFIGURE_ARGS+=	--enable-lirc
 > +.  endif
 > +.else
 > +CONFIGURE_ARGS+=	--disable-lirc
 > +.endif
 > +
 > [...]
 
 In this way I think it is possible to build pulseaudio with the `lirc'
 option also if the platform doesn't support lirc.
 
 What about adding the `lirc' option only if the platform supports it,
 e.g. something like (completely untested!):
 
  .include "../../comms/lirc/available.mk"
  
  PKG_OPTIONS_VAR=       PKG_OPTIONS.pulseaudio
  PKG_SUPPORTED_OPTIONS= avahi fftw gsettings x11
  if ${LIRC_AVAILABLE} == "yes"
  PKG_SUPPORTED_OPTIONS+= lirc
  .endif
  PKG_SUGGESTED_OPTIONS= avahi x11
  
  PLIST_VARS+=           ${PKG_SUPPORTED_OPTIONS}
  
  [...]
  
  .if !empty(PKG_OPTIONS:Mlirc)
  PLIST.lirc=		yes
  CONFIGURE_ARGS+=	--enable-lirc
  .include "../../comms/lirc/buildlink3.mk"
  .else
  CONFIGURE_ARGS+=	--disable-lirc
  .endif
  
  [...]
 
 Apart that, should buildlink3.mk be updated too to handle possible lirc
 bl3 include?
 
 
 Thanks!