Re: pkg/54327: pulseaudio: invalid PLIST due to lirc on Arch Linux

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

The following reply was made to PR pkg/54327; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <triaxx%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: leot%NetBSD.org@localhost
Subject: Re: pkg/54327: pulseaudio: invalid PLIST due to lirc on Arch Linux
Date: Tue, 25 Jun 2019 19:23:59 +0200

 >  Thanks Leonardo for the idea, I will test.
 
 It works file, thanks leot@! The patch is now:
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/audio/pulseaudio/Makefile,v
 retrieving revision 1.135
 diff -u -r1.135 Makefile
 --- Makefile	23 Jun 2019 04:46:20 -0000	1.135
 +++ Makefile	25 Jun 2019 11:12:30 -0000
 @@ -1,7 +1,7 @@
   # $NetBSD: Makefile,v 1.135 2019/06/23 04:46:20 tsutsui Exp $
 
   DISTNAME=	pulseaudio-12.2
 -PKGREVISION=	4
 +PKGREVISION=	5
   CATEGORIES=	audio
   MASTER_SITES=	https://freedesktop.org/software/pulseaudio/releases/
   EXTRACT_SUFX=	.tar.xz
 Index: PLIST
 ===================================================================
 RCS file: /cvsroot/pkgsrc/audio/pulseaudio/PLIST,v
 retrieving revision 1.29
 diff -u -r1.29 PLIST
 --- PLIST	25 Jul 2018 12:15:59 -0000	1.29
 +++ PLIST	25 Jun 2019 11:12:30 -0000
 @@ -147,6 +147,8 @@
   lib/pulse-${PULSELIBVER}/modules/module-intended-roles.so
   lib/pulse-${PULSELIBVER}/modules/module-ladspa-sink.a
   lib/pulse-${PULSELIBVER}/modules/module-ladspa-sink.so
 +${PLIST.lirc}lib/pulse-${PULSELIBVER}/modules/module-lirc.a
 +${PLIST.lirc}lib/pulse-${PULSELIBVER}/modules/module-lirc.so
   lib/pulse-${PULSELIBVER}/modules/module-loopback.a
   lib/pulse-${PULSELIBVER}/modules/module-loopback.so
   lib/pulse-${PULSELIBVER}/modules/module-match.a
 Index: options.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/audio/pulseaudio/options.mk,v
 retrieving revision 1.9
 diff -u -r1.9 options.mk
 --- options.mk	25 Jul 2018 12:15:59 -0000	1.9
 +++ options.mk	25 Jun 2019 11:12:30 -0000
 @@ -1,7 +1,12 @@
   # $NetBSD: options.mk,v 1.9 2018/07/25 12:15:59 adam Exp $
 
 +.include "../../comms/lirc/available.mk"
 +
   PKG_OPTIONS_VAR=	PKG_OPTIONS.pulseaudio
   PKG_SUPPORTED_OPTIONS=	avahi fftw gsettings x11
 +.if ${LIRC_AVAILABLE} == "yes"
 +PKG_SUPPORTED_OPTIONS+=	lirc
 +.endif
   PKG_SUGGESTED_OPTIONS=	avahi x11
   PLIST_VARS+=		${PKG_SUPPORTED_OPTIONS}
 
 @@ -14,13 +19,6 @@
   CONFIGURE_ARGS+=	--disable-avahi
   .endif
 
 -.if !empty(PKG_OPTIONS:Mgsettings)
 -PLIST.gsettings=	yes
 -CONFIGURE_ARGS+=	--enable-gsettings
 -.else
 -CONFIGURE_ARGS+=	--disable-gsettings
 -.endif
 -
   .if !empty(PKG_OPTIONS:Mfftw)
   CONFIGURE_ARGS+=	--with-fftw
   PLIST.fftw=		yes
 @@ -40,6 +38,21 @@
   CONFIGURE_ARGS+=	--without-fftw
   .endif
 
 +.if !empty(PKG_OPTIONS:Mgsettings)
 +PLIST.gsettings=	yes
 +CONFIGURE_ARGS+=	--enable-gsettings
 +.else
 +CONFIGURE_ARGS+=	--disable-gsettings
 +.endif
 +
 +.if !empty(PKG_OPTIONS:Mlirc)
 +PLIST.lirc=		yes
 +CONFIGURE_ARGS+=	--enable-lirc
 +.include "../../comms/lirc/buildlink3.mk"
 +.else
 +CONFIGURE_ARGS+=	--disable-lirc
 +.endif
 +
   .if !empty(PKG_OPTIONS:Mx11)
   .include "../../x11/libICE/buildlink3.mk"
   .include "../../x11/libSM/buildlink3.mk"