pkg/54367: audio/musepack error path relative to WRKDIR on macosx

[clement.bouvier.europe%gmail.com@localhost]

>Number:         54367
>Category:       pkg
>Synopsis:       audio/musepack error path relative to WRKDIR on macosx
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 11 06:15:00 +0000 2019
>Originator:     Clement Bouvier
>Release:        current
>Organization:
>Environment:
macosx Mojave 10.14.5
>Description:
audio/musepack fails to install because of path relative to WRKDIR in libmpcdec.dylib

=> Checking for missing run-time search paths in musepack-0rc475
ERROR: lib/libmpcdec.dylib: path relative to WRKDIR: /Users/cbouvier/prj/pkgsrc/audio/musepack/work/musepack_src_r475/libmpcdec/libmpcdec.dylib
*** Error code 1
>How-To-Repeat:
install audio/musepack on macosx with PKG_DEVELOPER = yes in mk.conf.
>Fix:
Let CMake manage the RPATH in adding an INSTALL statement in the CMakeLists.txt of the library.
The patch was tested on macosx and netbsd-8. The install seems ok.


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/audio/musepack/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	10 Oct 2014 11:19:29 -0000	1.2
+++ Makefile	11 Jul 2019 06:08:47 -0000
@@ -12,11 +12,9 @@
 
 USE_CMAKE=		yes
 
-INSTALLATION_DIRS=	lib
 
 post-install:
 	rm -rf ${DESTDIR}${PREFIX}/include/mpc/.svn/
-	${INSTALL_LIB} ${WRKSRC}/libmpcdec/libmpcdec.* ${DESTDIR}${PREFIX}/lib
 
 .include "../../audio/libcuefile/buildlink3.mk"
 .include "../../audio/libreplaygain/buildlink3.mk"
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/audio/musepack/distinfo,v
retrieving revision 1.3
diff -u -r1.3 distinfo
--- distinfo	18 Dec 2017 13:01:17 -0000	1.3
+++ distinfo	11 Jul 2019 06:08:47 -0000
@@ -5,4 +5,5 @@
 SHA512 (musepack_src_r475.tar.gz) = 23aa16152b27ba99ff7f4672b8f91562ee9ad829bbe1ee066693eabf69844ee9f8e4b3eebf1bac78e6994119fbb53b034479a1b996576aeecbfba7d797f130b0
 Size (musepack_src_r475.tar.gz) = 188737 bytes
 SHA1 (patch-CMakeLists.txt) = c4a9dd61c1f8691d8321e6ee5f6939cd44eb7a15
+SHA1 (patch-libmpcdec_CMakeLists.txt) = 88d67ad449cef416d96f2e519c10f3ebf856daeb
 SHA1 (patch-mpcenc_keyboard.c) = 42e038f003c64369e245e3688f6f0783bd2d443a
Index: patches/patch-libmpcdec_CMakeLists.txt
===================================================================
RCS file: patches/patch-libmpcdec_CMakeLists.txt
diff -N patches/patch-libmpcdec_CMakeLists.txt
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ patches/patch-libmpcdec_CMakeLists.txt	11 Jul 2019 06:08:47 -0000
@@ -0,0 +1,12 @@
+$NetBSD$
+
+--- libmpcdec/CMakeLists.txt.orig	2010-08-21 15:55:01.000000000 +0000
++++ libmpcdec/CMakeLists.txt
+@@ -1,6 +1,7 @@
+ include_directories(${libmpc_SOURCE_DIR}/include)
+ if(SHARED)
+   add_library(mpcdec SHARED huffman mpc_decoder mpc_reader streaminfo mpc_bits_reader mpc_demux requant synth_filter ${libmpc_SOURCE_DIR}/common/crc32)
++  install(TARGETS mpcdec LIBRARY DESTINATION lib)
+ else(SHARED)
+   add_library(mpcdec_static STATIC huffman mpc_decoder mpc_reader streaminfo mpc_bits_reader mpc_demux requant synth_filter ${libmpc_SOURCE_DIR}/common/crc32)
+ endif(SHARED)