Re: pkg/54353: audio/audacity build fails linking on netbsd-8/i386

["John D. Baker" <jdbaker%consolidated.net@localhost>]

The following reply was made to PR pkg/54353; it has been noted by GNATS.

From: "John D. Baker" <jdbaker%consolidated.net@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54353: audio/audacity build fails linking on netbsd-8/i386
Date: Fri, 12 Jul 2019 14:56:44 -0500 (CDT)

 On Fri, 12 Jul 2019, Onno van der Linden wrote:
 
 >  Looks like 
 >  
 >  .if ${MACHINE_ARCH} == "i386"
 >  # 64 bit atomic ops are required
 >  CXXFLAGS+=      -march=i586
 >  .endif
 >  
 >  might be needed in audacity/Makefile.
 
 Other packages have needed this addition over the years to build on
 32-bit x86.  The only machines I have that are not at least i586 class
 are ones I wouldn't be running 'audacity' on anyway, so the following
 patch:
 
 +Index: audio/audacity/Makefile
 +===================================================================
 +RCS file: /cvsroot/pkgsrc/audio/audacity/Makefile,v
 +retrieving revision 1.119
 +diff -u -p -r1.119 Makefile
 +--- audio/audacity/Makefile    4 Jun 2019 23:09:51 -0000       1.119
 ++++ audio/audacity/Makefile    12 Jul 2019 19:54:52 -0000
 +@@ -77,6 +77,11 @@ LIBS.NetBSD+=       -lcompat
 + 
 + INSTALLATION_DIRS+=   lib
 + 
 ++.if ${MACHINE_ARCH} == "i386"
 ++  # 64 bit atomic ops are required
 ++  CXXFLAGS+=      -march=i586
 ++.endif
 ++
 + # regen Makefile.in to avoid being built as shared libraries
 + pre-configure:
 +       cd ${WRKSRC}/lib-src/portaudio-v19 && ${PKGSRC_SETENV} autoreconf -fiv
 
 lets "audio/audacity" build on my NetBSD/i386 platforms.
 
 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645