Re: pkg/54418: audio/alure bad header directory naming in PLIST under macos

[clément bouvier <clement.bouvier.europe%gmail.com@localhost>]

The following reply was made to PR pkg/54418; it has been noted by GNATS.

From: =?utf-8?Q?cl=C3=A9ment_bouvier?= <clement.bouvier.europe%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: macos-pkg-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/54418: audio/alure bad header directory naming  in PLIST
 under macos
Date: Mon, 29 Jul 2019 01:09:44 +0400

 Hi David,
 
 Thank you, I will remember it. The openalcldir is not included in =
 PLIST_VARS ?
 
 Clement
 
 > Le 28 juil. 2019 =C3=A0 23:15, David Holland =
 <dholland-pbugs%netbsd.org@localhost> a =C3=A9crit :
 >=20
 > The following reply was made to PR pkg/54418; it has been noted by =
 GNATS.
 >=20
 > From: David Holland <dholland-pbugs%netbsd.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc:=20
 > Subject: Re: pkg/54418: audio/alure bad header directory naming  in =
 PLIST
 > under macos
 > Date: Sun, 28 Jul 2019 19:12:00 +0000
 >=20
 > On Sun, Jul 28, 2019 at 03:35:00PM +0000, =
 clement.bouvier.europe%gmail.com@localhost wrote:
 >> +.include "../../mk/bsd.prefs.mk"
 >> +
 >> +PLIST_VARS+=3D    alincldir
 >> +
 >> +.if ${OPSYS} !=3D "Darwin"
 >> +PLIST.alincldir=3D	yes
 >> +.endif
 >> +
 >=20
 >> -include/AL/alure.h
 >> +${PLIST.alincldir}include/AL/alure.h
 >=20
 > Better way to do this is:
 >=20
 >> +.include "../../mk/bsd.prefs.mk"
 >> +
 >> +PLIST_VARS+=3D    alincldir
 >> +
 >> +.if ${OPSYS} =3D=3D "Darwin"
 >> +PLIST.openalincldir=3D	yes
 >> +.else
 >> +PLIST.alincldir=3D		yes
 >> +.endif
 >> +
 >=20
 >> -include/AL/alure.h
 >> +${PLIST.openalincldir}include/OpenAL/alure.h
 >> +${PLIST.alincldir}include/AL/alure.h
 >=20
 > because in addition to being clearer to read it also continues to work
 > if the conditional becomes more complicated.
 >=20
 > --=20
 > David A. Holland
 > dholland%netbsd.org@localhost
 >=20