Re: pkg/54848 (editors/emacs-snapshot jansson option mistakenly depend on x11 option)

[Makoto Fujiwara <makoto%if.t.u-tokyo.ac.jp@localhost>]

The following reply was made to PR pkg/54848; it has been noted by GNATS.

From: Makoto Fujiwara <makoto%if.t.u-tokyo.ac.jp@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54848 (editors/emacs-snapshot jansson option mistakenly depend on x11 option)
Date: Sat, 11 Jan 2020 20:25:31 +0900

 Hi, thanks for the report, and how-to-fix:
 I don't know how to check if jansson option is enabled, so
 just I've checked the system-configuration-options variable.
 
 Anyway, I'll commit the fix.
 Following lines show how to confirm the change. (Am I right ?)
 
 - check exisiting emacs
 - cd /usr/pkgsrc/editors/emacs-snapshot
   make clean
   make replace
   (start)  emacs=20
   M-x describe-variable
       system-configuration-options
       and '--without-json' found
 
 - Apply the patch
   make clean
   env PKG_OPTIONS.emacs=3D'jansson -x11' make replace
   '--without-json' NOT found
 
 (before)
 --------------------------------------------
 system-configuration-options is a variable defined in ¡C source code¢.
 Its value is
 
 "--srcdir=3D/tmp/editors/emacs-snapshot/work/emacs-27.0.60
 --localstatedir=3D/var
 --without-rsvg
 --without-imagemagick
 --without-json
 --x-includes=3D/usr/X11R7/include
 --x-libraries=3D/usr/X11R7/lib
 --with-x-toolkit=3Dgtk3
 --prefix=3D/usr/pkg
 --build=3Dx86_64--netbsd
 --host=3Dx86_64--netbsd
 --infodir=3D/usr/pkg/info
 --mandir=3D/usr/pkg/man
 --enable-option-checking=3Dyes
 'CFLAGS=3D-O2
 -D_FORTIFY_SOURCE=3D2
 -I/usr/pkg/include
 -I/usr/include
 -I/usr/pkg/include/glib-2.0
 -I/usr/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/X11R7/include
 -I/usr/X11R7/include/freetype2
 -I/usr/X11R7/include/libdrm'
 'CPPFLAGS=3D-I/usr/pkg/include
 -I/usr/include
 -I/usr/pkg/include/glib-2.0
 -I/usr/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/X11R7/include
 -I/usr/X11R7/include/freetype2
 -I/usr/X11R7/include/libdrm'
 'LDFLAGS=3D-L/usr/pkg/lib
 -Wl,-R/usr/pkg/lib
 -L/usr/lib -Wl,-R/usr/lib
 -L/usr/X11R7/lib
 -Wl,-R/usr/X11R7/lib'"
 --------------------------------------------
 
 
 (after)
 --------------------------------------------
 
 system-configuration-options is a variable defined in `C source code'.     =
                                                 =20
 Its value is                                                               =
                                                 =20
 
 "--srcdir=3D/tmp/editors/emacs-snapshot/work/emacs-27.0.60
 --localstatedir=3D/var
 --without-dbus
 --without-xml2
 --without-gnutl\ s
 --without-x --without-xpm
 --without-jpeg
 --without-tiff
 --without-gif
 --without-png
 --x-includes=3D/usr/X11R7/include
 --x-l\
 ibraries=3D/usr/X11R7/lib
 --prefix=3D/usr/pkg
 --build=3Dx86_64--netbsd
 --host=3Dx86_64--netbsd
 --infodir=3D/usr/pkg/info
 --mandir=3D/us\ r/pkg/man
 --enable-option-checking=3Dyes
 'CFLAGS=3D-O2
 -D_FORTIFY_SOURCE=3D2
 -I/usr/pkg/include
 -I/usr/pkg/include/glib-2.0
 -I/us\
 r/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/include
 -I/usr/X11R7/include/freetype2'
 'CPPFLAGS=3D-I/usr/\
 pkg/include
 -I/usr/pkg/include/glib-2.0
 -I/usr/pkg/include/gio-unix-2.0
 -I/usr/pkg/lib/glib-2.0/include
 -I/usr/include -I/u\
 sr/X11R7/include/freetype2'
 'LDFLAGS=3D-L/usr/pkg/lib
 -Wl,-R/usr/pkg/lib
 -L/usr/lib -Wl,-R/usr/lib
 -L/usr/X11R7/lib
 -Wl,-R/us\ r/X11R7/lib'"
                                                                            =
                                                 =20
 Documentation:                                                             =
                                                 =20
 String containing the configuration options Emacs was built with.          =
                                                 =20