pkg/54868: www/firefox enables oss on some platforms, even though support was removed

[mforney%mforney.org@localhost]

>Number:         54868
>Category:       pkg
>Synopsis:       www/firefox enables oss on some platforms, even though support was removed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 18 03:10:00 +0000 2020
>Originator:     Michael Forney
>Release:        pkgsrc trunk, 2020-01-17
>Organization:
>Environment:
Linux arrow 5.4.7+ #103 SMP Fri Jan 3 16:39:41 PST 2020 x86_64
>Description:
The oss cubeb patch was removed during the update to 71.0, but several other patches still try to enable it by default on Linux, DragonFly, FreeBSD, and GNU/kFreeBSD.

This results in a configure error on those platforms:

==============================
FATAL ERROR PROCESSING MOZBUILD FILE
==============================

The error occurred while processing the following file or one of the files it includes:

    /src/pkgsrc/www/firefox/work/firefox-72.0.1/media/libcubeb/src/moz.build

The error occurred when validating the result of the execution. The reported error is:

    File listed in SOURCES does not exist: '/src/pkgsrc/www/firefox/work/firefox-72.0.1/media/libcubeb/src/cubeb_oss.c'


*** Error code 1
>How-To-Repeat:
Attempt to build www/firefox on Linux, DragonFly, FreeBSD, or GNU/kFreeBSD.
>Fix:
Remove the remaining OSS hunks in the patches:
https://github.com/NetBSD/pkgsrc/compare/trunk...michaelforney:firefox-oss.patch