pkg/54891: devel/arcanist do-install target uses pax with intermixed options and operands

[mforney%mforney.org@localhost]

>Number:         54891
>Category:       pkg
>Synopsis:       devel/arcanist do-install target uses pax with intermixed options and operands
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 24 22:20:00 +0000 2020
>Originator:     Michael Forney
>Release:        pkgsrc trunk, 2020-01-24
>Organization:
>Environment:
Linux arrow 5.4.13+ #104 SMP Tue Jan 21 15:51:57 PST 2020 x86_64
>Description:
devel/arcanist's do-install target makes the following call to pax(1):

${PAX} -rw * -s',.*\.orig$$,,' ${DESTDIR}${PREFIX}/${ARCANISTDIR}

Some implementations of pax consider all arguments after the first operand to be operands, resulting in the error:

===> Installing for arcanist-20170609nb2
=> Generating pre-install file lists
=> Creating installation directories
cd /src/pkgsrc/devel/arcanist/work/arcanist-0c53a35d30e924f902510eb2e497ae5934209304 &&  /bin/pax -rw * -s',.*\.orig$,,'  /src/pkgsrc/devel/arcanist/work/.destdir/pkg/share/arcanist
pax: Unable to access -s,.*\.orig$,,: No such file or directory
pax: WARNING! These file names were not selected:
-s,.*\.orig$,,
*** Error code 1

>How-To-Repeat:
Attempt to build devel/arcanist using a pax implementation that doesn't support arguments in this order. I ran into the issue with OpenBSD pax ported to Linux, linked against musl libc.
>Fix:
https://github.com/NetBSD/pkgsrc/compare/trunk...michaelforney:arcanist-pax.patch