pkg/55188: libsoup FTBFS on RHEL-7. Needs to define _BSD_SOURCE.

[eric%garver.life@localhost]

>Number:         55188
>Category:       pkg
>Synopsis:       libsoup FTBFS on RHEL-7. Needs to define _BSD_SOURCE.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Apr 20 12:55:00 +0000 2020
>Originator:     Eric Garver
>Release:        pkgsrc-2020Q1
>Organization:
>Environment:
$ uname -a
Linux $HOST 3.10.0-693.21.1.el7.x86_64 #1 SMP Fri Feb 23 18:54:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
>Description:
Fails to build because u_char is not defined. It's defined in sys/types.h, but wrapped in __USE_BSD which is glibc internal and gets defined if _BSD_SOURCE is defined [1].

[1]: Search "__USE_BSD" here https://lwn.net/Articles/590381/

-->8--

[5/170] Compiling C object 'libsoup/275ffb9@@soup-2.4@sha/soup-address.c.o'.
FAILED: libsoup/275ffb9@@soup-2.4@sha/soup-address.c.o
cc -Ilibsoup/275ffb9@@soup-2.4@sha -Ilibsoup -I../libsoup -I. -I../ -I/home/egarver/pkg-2020Q1/include/glib-2.0 -I/home/egarver/pkg-2020Q1/lib/glib-2.0/include -I/home/egarv
er/pkg-2020Q1/include -I/home/egarver/pkg-2020Q1/include/libxml2 -I/usr/include -I/home/egarver/pkg-2020Q1/include/gio-unix-2.0 -I/home/egarver/pkg-2020Q1/include/python3.7
-fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=c89 -D_DEFAULT_SOURCE -DHAVE_CONFIG_H -Wall -Wmissing-include-dirs -Wpointer-arith -Winit-self -Wdeclaration-aft
er-statement -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=aggregate-return -Werror=format=2 -Wstrict-prototypes -Wno-format-zero-length -O2 -D_FO
RTIFY_SOURCE=2 -fPIC -pthread '-DG_LOG_DOMAIN="libsoup"' -DLIBSOUP_COMPILATION -fvisibility=hidden -MD -MQ 'libsoup/275ffb9@@soup-2.4@sha/soup-address.c.o' -MF 'libsoup/275f
fb9@@soup-2.4@sha/soup-address.c.o.d' -o 'libsoup/275ffb9@@soup-2.4@sha/soup-address.c.o' -c ../libsoup/soup-address.c
In file included from /usr/include/resolv.h:65:0,
                 from /home/egarver/pkgsrc/net/libsoup/work/.buildlink/include/glib-2.0/gio/gnetworking.h:44,
                 from ../libsoup/soup-address.c:14:
/usr/include/arpa/nameser.h:115:8: error: unknown type name 'u_char'
  const u_char *_msg, *_eom;
        ^~~~~~
>How-To-Repeat:
$ cd pkgsrc/net/libsoup
$ bmake
>Fix:
$ cd pkgsrc/net/libsoup
$ bmake clean
$ bmake CFLAGS="-D_BSD_SOURCE"