pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

pkg/55203: pkgsrc firefox-75.0 patch has suspicious chunk



>Number:         55203
>Category:       pkg
>Synopsis:       pkgsrc firefox-75.0 patch has suspicious chunk
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 24 02:55:00 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0
>Organization:
>Environment:
System: NetBSD mirage 9.0 NetBSD 9.0 (GENERIC) #22: Sat Apr 4 05:28:10 JST 2020 tsutsui@mirage:/s/netbsd-9/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
pkgsrc/www/firefox/patches/patch-browser_app_profile_firefox.js has
the following chunk to add pkgsrc specific settings:
---
+// Select UI locale from LANG/LC_MESSAGE environmental variables
+pref("intl.locale.requested", "");
+
+// Enable system addons, for example langpacks from www/firefox-l10n
+pref("extensions.autoDisableScopes", 11);
+
+// Disable multiprocess window support. Workaround for PR 53273.
+pref("browser.tabs.remote.autostart", false);
+

---

but installed pkg/lib/firefox/browser/defaults/preferences/firefox.js
seems to have the same settings in different lines:
---
% grep -n autoDisableScopes /usr/pkg/lib/firefox/browser/defaults/preferences/firefox.js
55:pref("extensions.autoDisableScopes", 15);
1614:pref("extensions.autoDisableScopes", 11);
% grep -n autostart /usr/pkg/lib/firefox/browser/defaults/preferences/firefox.js
1414:pref("browser.tabs.remote.autostart", true);
1617:pref("browser.tabs.remote.autostart", false);
% 
---
Note fuzz number seems a bit large (~1610 vs 1865),
so it should be regenerated anyway?

>How-To-Repeat:
Patch inspection.

>Fix:
Explicitly override original settings?

---
Izumi Tsutsui



Home | Main Index | Thread Index | Old Index