pkg/55321: Cygwin, devel/popt error: static declaration of 'glob_pattern_p' follows non-static declaration

[chwalek%poczta.onet.pl@localhost]

>Number:         55321
>Category:       pkg
>Synopsis:       Cygwin, devel/popt error: static declaration of 'glob_pattern_p' follows non-static declaration
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 30 17:30:00 +0000 2020
>Originator:     Pawel Chwalowski
>Release:        pkgsrc-2020Q1
>Organization:
>Environment:
CYGWIN_NT-10.0 xxxx2 3.1.4(0.340/5/3) 2020-02-19 08:49 x86_64 Cygwin
>Description:
I can't compile devel/popt on Cygwin.


chwal@xxxx2 ~/NetBSD/pkgsrc/devel/popt

$ bmake
=> Bootstrap dependency digest>=20010302: found digest-20190127
=> Bootstrap dependency tnftp-[0-9]*: found tnftp-20151004nb2
===> Skipping vulnerability checks.
WARNING: No /home/chwal/pkg/pkgdb/pkg-vulnerabilities file found.
WARNING: To fix run: `/home/chwal/pkg/sbin/pkg_admin -K /home/chwal/pkg/pkgdb fetch-pkg-vulnerabilities'.
===> Building for popt-1.16nb2
/home/chwal/pkg/bin/gmake  all-recursive
gmake[1]: Entering directory '/home/chwal/NetBSD/pkgsrc/devel/popt/work/popt-1.16'
Making all in po
gmake[2]: Entering directory '/home/chwal/NetBSD/pkgsrc/devel/popt/work/popt-1.16/po'
gmake[2]: Leaving directory '/home/chwal/NetBSD/pkgsrc/devel/popt/work/popt-1.16/po'
Making all in .
gmake[2]: Entering directory '/home/chwal/NetBSD/pkgsrc/devel/popt/work/popt-1.16'
/bin/sh ./libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.  -I. -I. -I/home/chwal/pkg/include  -O -I/home/chwal/pkg/include -Wall -W -D_GNU_SOURCE -D_REENTRANT -MT poptconfig.lo -MD -MP -MF .deps/poptconfig.Tpo -c -o poptconfig.lo poptconfig.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/home/chwal/NetBSD/pkgsrc/devel/popt/work/.buildlink/include -O -Wall -W -D_GNU_SOURCE -D_REENTRANT -MT poptconfig.lo -MD -MP -MF .deps/poptconfig.Tpo -c poptconfig.c  -DDLL_EXPORT -DPIC -o .libs/poptconfig.o
poptconfig.c:52:1: error: static declaration of 'glob_pattern_p' follows non-static declaration
   52 | glob_pattern_p (const char * pattern, int quote)
      | ^~~~~~~~~~~~~~
In file included from poptconfig.c:25:
/usr/include/glob.h:104:15: note: previous declaration of 'glob_pattern_p' was here
  104 | int DLLEXPORT glob_pattern_p (const char *, int);
      |               ^~~~~~~~~~~~~~
poptconfig.c: In function 'poptReadConfigFile':
poptconfig.c:402:9: warning: variable 'xx' set but not used [-Wunused-but-set-variable]
  402 |     int xx;
      |         ^~
gmake[2]: *** [Makefile:528: poptconfig.lo] Error 1
gmake[2]: Leaving directory '/home/chwal/NetBSD/pkgsrc/devel/popt/work/popt-1.16'
gmake[1]: *** [Makefile:628: all-recursive] Error 1
gmake[1]: Leaving directory '/home/chwal/NetBSD/pkgsrc/devel/popt/work/popt-1.16'
gmake: *** [Makefile:383: all] Error 2
*** Error code 2

Stop.
bmake[1]: stopped in /home/chwal/NetBSD/pkgsrc/devel/popt
*** Error code 1

Stop.
bmake: stopped in /home/chwal/NetBSD/pkgsrc/devel/popt

chwal@zurg2 ~/NetBSD/pkgsrc/devel/popt
$

>How-To-Repeat:
Run bmake in devel/popt on the Cygwin 
>Fix: